Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "DD Store Lock" #24440

Closed
wants to merge 1 commit into from
Closed

Revert "DD Store Lock" #24440

wants to merge 1 commit into from

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Sep 3, 2018

Reverts #24378

The original PR causes a set of failures in IB tests (11624.0, 11626.0, 11642.0, 12024.0, 24034.0).
Temporarily reverting the change, pending a fixed version.

@cmsbuild cmsbuild added this to the CMSSW_10_3_X milestone Sep 3, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24440/6273

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

DetectorDescription/Core
DetectorDescription/RegressionTest
GeometryReaders/XMLIdealGeometryESSource
MagneticField/GeomBuilder

@perrotta, @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@namapane this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 3, 2018

please test workflow 11626.0,12024.0,24034.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30214/console Started: 2018/09/03 11:27

ianna
ianna reviewed Sep 3, 2018
View reviewed changes
DetectorDescription/Core/src/DDCompactView.cc
DDRotation::StoreT::instance().setReadOnly( false );
rep_ = std::make_unique<DDCompactViewImpl>( DDLogicalPart( name ));
worldpos_ = std::make_unique<DDPosData>( DDTranslation(), DDRotation(), 0 );
DDMaterial::StoreT::instance().setReadOnly(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiocos - this is the only change needed to revert the store lock. I'll submit a new PR for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianna, ok, please do it, so as we may test and integrate it asap

@ianna
Copy link
Contributor

ianna commented Sep 3, 2018

@fabiocos - It's probably better if I submit a smaller fix for it - just not to lock the stores:
#24440 (review)

@ianna
Copy link
Contributor

ianna commented Sep 3, 2018

@fabiocos - please take this one instead:
#24441

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

-1

Tested at: fafe6ed

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24440/30214/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
24034.0 step2

runTheMatrix-results/24034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D28_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D28+RecoFullGlobal_2023D28+HARVESTFullGlobal_2023D28/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D28_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D28+RecoFullGlobal_2023D28+HARVESTFullGlobal_2023D28.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2018

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fabiocos fabiocos closed this Sep 3, 2018
@smuzaffar smuzaffar deleted the revert-24378-dd-store-lock branch December 19, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianna ianna ianna left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-notrun geometry-pending orp-pending pending-signatures reconstruction-pending tests-rejected
Projects
None yet
Milestone
CMSSW_10_3_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabiocos @cmsbuild @ianna