Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spurious file #24483

Merged
merged 1 commit into from Sep 8, 2018
Merged

Remove spurious file #24483

merged 1 commit into from Sep 8, 2018

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Sep 7, 2018

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2018

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

RecoLocalCalo/HGCalRecProducers

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @sethzenz, @felicepantaleo, @kpedro88, @lgray, @cseez, @pfs this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30292/console Started: 2018/09/07 11:44

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24483/30292/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3143975
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3143776
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2018

+1

  • Old and unused configuration, presumably kept for possible backup, removed: the actual one is created by the fillDescription() method of HGCalLayerClusterProducer
  • Jenkins tests pass with no changes

@kpedro88
Copy link
Contributor

kpedro88 commented Sep 7, 2018

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Sep 8, 2018

+1

@cmsbuild cmsbuild merged commit 4459a31 into cms-sw:master Sep 8, 2018
@rovere rovere deleted the removeSpuriousFile branch September 11, 2018 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants