ZDC/RPD QIE10 Digis DQM online

[BetterWang]

Online DQM monitoring for ZDC/RPD detector on QIE10 Digis.

[BetterWang]

@mandrenguyen HI software contact person.

[cmsbuild]

The code-checks are being triggered in jenkins.

[andrius-k]

please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24495/6353

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24495/6353/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24495/6353/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[abdoulline]

@DryRun @deguio
Just to draw your attention

[deguio]

hi @BetterWang
why don't you update the existing ZDCTask instead of creating a new one?

[BetterWang]

Hi @deguio , the old one was for QIE8.

[andrius-k]

Hi Quan,

Is it really necessary to use null-terminated strings (.c_str())? The bot seems to be complaining about that in code checks.

[deguio]

@BetterWang right..

[BetterWang]

right...

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24495/6362

[cmsbuild]

A new Pull Request was created by @BetterWang (Quan Wang) for master.

It involves the following packages:

DQM/HcalTasks

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@DryRun, @deguio this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[deguio]

ok. let me rephrase. do you really need to duplicate an existing plugin instead of adapting the existing one to use the new QIE10 collection?

[andrius-k]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24495/6406

[cmsbuild]

Pull request #24495 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30410/console Started: 2018/09/14 10:44

[cmsbuild]

+1
Tested at: 2963bbd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24495/30410/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24495/30410/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3147366
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3147168
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

@andrius-k @jfernan2 could you please review again this PR?

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[abdoulline]

@BetterWang
"...another PR to include this to online and offline DQM sequence."

• Was it done?