Fix SimPFProducer for electrons #24498
Conversation
In few cases, with the introduction of the graph-base calo-particles, some electron was either not releasing directly hits in the calorimeters or, if it had, they could have been rejected due to selection and threshold effects. While the first case was already covered in the code (i.e. the no hit one), the second case was not. This bug caused the electron to be included w/o its sub-components that would have been later on added as separate PFCandidates. This PR fix the second use case.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24498/6356 |
|
A new Pull Request was created by @rovere (Marco Rovere) for master. It involves the following packages: RecoParticleFlow/PFSimProducer @perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test workflow 24034.0 |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Please refer to the commit messages for further information.
There are also useful slides in here and here
Also, a new MonitorElement has been added in order to monitor the issue: the previously added Validation MonitorElements were not able to spot this issue.
I do expect some regression, but it fixes the issue.
The fix is geometry independent.
type bug-fix