Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cosmic track splitting validation #2450

Merged

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Feb 13, 2014

This is an update to the cosmic track splitting validation. It adds more variables into the tree, including the errors for split and original track variables.

I was asked by the conveners to create this pull request for the cosmic track splitting validation.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes for CMSSW_5_3_X.

Update to cosmic track splitting validation

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @frmeier this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor

diguida commented Feb 21, 2014

@cmsbuild @smuzaffar
Please run the tests. It is a back port of #2452 passing tests and going for integration.

@rcastello
Copy link

Can @cmsbuild @smuzaffar please run the test? This is a backport of something already merged in 71X via the PR #2452

@rcastello
Copy link

+1
(provided jenkins agrees)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@davidlange6
Copy link
Contributor

+1

@smuzaffar
Copy link
Contributor

+tested

smuzaffar added a commit that referenced this pull request Mar 5, 2014
Update to cosmic track splitting validation
@smuzaffar smuzaffar merged commit 66886c6 into cms-sw:CMSSW_5_3_X Mar 5, 2014
@hroskes hroskes deleted the cosmic-track-splitting-update-53X branch November 3, 2014 11:16
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants