Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable IMT for merging of NanoAOD. #24508

Merged
merged 1 commit into from Sep 12, 2018

Conversation

bbockelm
Copy link
Contributor

As documented in CMSCOMPPR-3348, IMT triggers a crash in ROOT due to the fact that NanoAOD adds branches to the tree. This patch is a simple workaround - we disable IMT for the merge jobs (which are single core anyway) - until the ROOT issue is resolved.

I tested this by performing:

>>> import Configuration.DataProcessing.Merge
>>> p = Configuration.DataProcessing.Merge.mergeProcess(["afile.root"],mergeNANO=True)
>>> print p.dumpPython()

and hand-inspecting the resulting python.

As documented in CMSCOMPPR-3348, IMT triggers a crash in ROOT due
to the fact that NanoAOD adds branches to the tree.  This patch
is a simple workaround - we disable IMT for the merge jobs (which
are single core anyway) - until the ROOT issue is resolved.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bbockelm (Brian Bockelman) for CMSSW_10_2_X.

It involves the following packages:

Configuration/DataProcessing

@cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@arizzi
Copy link
Contributor

arizzi commented Sep 11, 2018

I think you can create the same PR on the master branch from the very same branch (I assume the usual policy apply for master vs stable branches, so the master PR is needed)

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2018

@fabiocos
Copy link
Contributor

+operations

the DataProcessing merge test output shows modifications consistent with the proposed change

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild cmsbuild merged commit a8a031d into cms-sw:CMSSW_10_2_X Sep 12, 2018
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24508/30371/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2985426
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2985234
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants