HCALDQM: Improve LED monitoring (10_3_X)

[DryRun]

Improves monitoring of the HCAL calibration LEDs:

• Detector coordinates of LED calibration channels are configurable in python.
• Misfires (from high ADC signal in CUs) are counted vs. LS.
• LED monitoring is done in both online and offline DQM, to help certification in the event of misfires.
• HF LED monitoring added (previously only HE).

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24515/6381

[cmsbuild]

A new Pull Request was created by @DryRun (David Yu) for master.

It involves the following packages:

DQM/HcalCommon
DQM/HcalTasks

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@deguio this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[andrius-k]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30366/console Started: 2018/09/12 17:37
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30372/console Started: 2018/09/12 22:52

[DryRun]

Sorry, I realized that I should combine this with some other non-factorizable changes, so I added two more commits. It should be set now.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24515/6386

[cmsbuild]

Pull request #24515 was updated. @kmaeshima, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

[cmsbuild]

+1
Tested at: 6ffd276
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24515/30372/summary.html

[cmsbuild]

Comparison job queued.

[andrius-k]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30388/console Started: 2018/09/13 12:20

[cmsbuild]

+1
Tested at: 6ffd276
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24515/30388/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24515/30388/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3147341
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3147143
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 3672.57 KiB( 31 files compared)
• DQMHistoSizes: changed ( 250202.181,... ): 166.935 KiB Hcal/DigiTask
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1