New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move computation of debug-only variables in SiPixelDigitizerAlgorithm inside TP_DEBUG #24517
Move computation of debug-only variables in SiPixelDigitizerAlgorithm inside TP_DEBUG #24517
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24517/6382 |
A new Pull Request was created by @perrotta for master. It involves the following packages: SimTracker/SiPixelDigitizer @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
-1 Tested at: c6e288b You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
The relvals timed out after 2 hours. |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
Avoid uselessly computing local variables of SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizerAlgorithm.cc which are only needed inside a
#ifdef TP_DEBUG
clause