Move tinyxml->tinixml2 in CalibTracker/StandaloneTrackerTopology pkg #24518
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24518/6384 |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: CalibTracker/StandaloneTrackerTopology @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 Tested at: 98775ef You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testTrackerAlignmentPayloadInspector had ERRORS |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
In tinyxml xmlDoc.LoadFile(xmlFileName.c_str()) was returning true on success, while xml2 returns 0. Also the char comparison on line 25 was not working
cmsbuild
added
code-checks-pending
comparison-pending
and removed
code-checks-approved
comparison-available
tests-rejected
labels
|
The code-checks are being triggered in jenkins. |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24518/6405 |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Recently we added tinyxml2 external and now we are moving pkgs that were using tinyxml to tinyxml2.