Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "ppReco" label in relval output dataset names for batch injection #24521

Merged
merged 1 commit into from Sep 14, 2018

Conversation

zhenhu
Copy link
Contributor

@zhenhu zhenhu commented Sep 12, 2018

No description provided.

@kpedro88
Copy link
Contributor

@smuzaffar the bot missed this one, can you check?

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @zhenhu (Zhen Hu) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @prebello, @zhenhu, @kpedro88, @fabozzi, @pgunnell, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@zhenhu
Copy link
Contributor Author

zhenhu commented Sep 12, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30385/console Started: 2018/09/13 00:23

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24521/30385/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2996019
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2995826
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 32 DQM output files

@zhenhu
Copy link
Contributor Author

zhenhu commented Sep 13, 2018

+1

@fabiocos
Copy link
Contributor

@kpedro88 any objection? This looks ok and trivial to me

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6998471 into cms-sw:master Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants