sync OMTF code (as in tag omtfdev_mk20). #24539
Conversation
Changes includes: - fix for missing CSC offset in raw to digi - fixed mem leaks - allow for emulator reconstruction in bx other than 0. - new omtf algorithm (sc-called v5, compatible with the one prepared for P5 running); the new algo is planned to be enabled by o2o with omtf algo key 'omtf_algo_base/v4'; until then old algorithm is enabled.
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24539/6416 |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @rekovic for master. It involves the following packages: EventFilter/L1TRawToDigi @nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
The improvement is based on assigning eta from vetoed muon candidates in GM, in case the best candidate is based on hit from DT and has no eta assigned (frequent for DT hits in wheel2). The switch to new eta assignment based on o2o'ed config. 2) minor bugfix in emulator wrt firmware for negative phi assigned use floor instead of taking int. It is very rare case, in most have positive resulting phi is positive. 3) minor bugfix in emulator wrt firmware in cases where there are 2 hits of the same parameters does not try to merge them (for DT and CSC hits). In firmware they occupy tow inputs. Very rare usecase.
cmsbuild
added
code-checks-pending
and removed
code-checks-approved
comparison-available
tests-approved
labels
rekovic
changed the title
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24539/6463 |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready The workflows 4.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Comparison Summary:
|
|
@rekovic I see that not only 2018 workflows are affected (136.85) but also 2017 ones (136.788). Is this intended? |
|
@rekovic could you please answer my question? I would like to merge this PR, but I would like to be sure that the DQM checks are understood |
|
@fabiocos Yes, this will affect re-emulation of both 2017 and 2018 data. |
|
+1 |
PR 10_3_X
Changes includes:
the new algo is planned to be enabled by o2o with omtf algo key 'omtf_algo_base/v4';
until then old algorithm is enabled.
The above changes in packer/unpacker and algorithm in emulator is only affecting re-emulation of data (DQM offline/online) and not effecting MC production. Change in emulator does not effect MC production since the MC Global Tag is not updated.