Tau offline DQM update #24547

mbluj · 2018-09-14T15:58:21Z

Revision of histograms used for offline tau validation and some code modernization. Description from an author of the update (@aspiezia):

The following changes have been made:

Clean the amount of DQM plots. Now only decayMode and iso efficiencies are shown for RealData/QCD; decayMode and electron discriminators efficiencies for RealElectrons/ZEE; decayMode and muon discriminators efficiencies for RealMuons/ZMM.
A summary plot showing the inclusive efficiency for all the discriminators is added.
The plots for the number of taus of each event are now correctly initizialized (before it was not the case).

FYI, @swozniewski

plots for DQM tau

cmsbuild · 2018-09-14T15:58:43Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-09-14T16:01:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24547/6426

cmsbuild · 2018-09-14T16:01:45Z

A new Pull Request was created by @mbluj for master.

It involves the following packages:

Validation/RecoTau

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

andrius-k · 2018-09-17T11:11:51Z

@mbluj I can't seem to find you in the DQM Contacts list. Could you please introduce yourself briefly?

mbluj · 2018-09-17T11:31:15Z

Hello,
I am not a DQM contact, but one of RECO contacts of Tau POG and as such I am responsible for preparing tau related code (RECO, DQM, etc.) for integration with the official CMSSW. It is why I pushed this PR.
Content of the PR is agreed with Tau POG conveners (@steggema @rmanzoni) and consists of rationalization of list of histograms produced to validate tau reconstruction as mentioned in the description. The rationalization is twofold:

histograms which are not relevant for checks in specific samples are removed from configurations run on those samples,
summary histograms was added for a quick inspection.

I hope it answers your question.

Best,
Michał Bluj

andrius-k · 2018-09-19T12:57:21Z

please test

cmsbuild · 2018-09-19T12:58:34Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30507/console Started: 2018/09/19 15:50

andrius-k · 2018-09-19T12:59:56Z

@mbluj If you work in Tau DQM I think you should appear in the DQM contacts list. You can register yourself by clicking manage next to the appropriate group in this page.

cmsbuild · 2018-09-19T16:08:28Z

+1
Tested at: 74a413a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24547/30507/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
74a413a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24547/30507/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24547/30507/git-merge-result

cmsbuild · 2018-09-19T16:08:31Z

Comparison job queued.

cmsbuild · 2018-09-27T11:16:46Z

Comparison job queued.

cmsbuild · 2018-09-27T12:48:22Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24547/30683/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2994306
DQMHistoTests: Total failures: 1578
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2992531
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -57864.697 KiB( 31 files compared)
DQMHistoSizes: changed ( 25.0,... ): -17.360 KiB RecoTauV/hpsPFTauProducerZMM_hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr3HitsdR03
DQMHistoSizes: changed ( 25.0,... ): -17.360 KiB RecoTauV/hpsPFTauProducerZEE_hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr3HitsdR03
DQMHistoSizes: changed ( 25.0,... ): -17.280 KiB RecoTauV/hpsPFTauProducerZEE_hpsPFTauDiscriminationByLooseCombinedIsolationDBSumPtCorr3HitsdR03
DQMHistoSizes: changed ( 25.0,... ): -17.280 KiB RecoTauV/hpsPFTauProducerZMM_hpsPFTauDiscriminationByTightCombinedIsolationDBSumPtCorr3HitsdR03
DQMHistoSizes: changed ( 25.0,... ): -17.280 KiB RecoTauV/hpsPFTauProducerZEE_hpsPFTauDiscriminationByTightCombinedIsolationDBSumPtCorr3HitsdR03
DQMHistoSizes: changed ( 25.0,... ): -17.280 KiB RecoTauV/hpsPFTauProducerZMM_hpsPFTauDiscriminationByLooseCombinedIsolationDBSumPtCorr3HitsdR03
DQMHistoSizes: changed ( 25.0,... ): -17.040 KiB RecoTauV/hpsPFTauProducerZMM_hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr3Hits
DQMHistoSizes: changed ( 25.0,... ): -17.040 KiB RecoTauV/hpsPFTauProducerZEE_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1PWdR03oldDMwLT
DQMHistoSizes: changed ( 25.0,... ): -17.040 KiB RecoTauV/hpsPFTauProducerZTT_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1PWdR03oldDMwLT
DQMHistoSizes: changed ( 25.0,... ): -17.040 KiB RecoTauV/hpsPFTauProducerQCD_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1PWdR03oldDMwLT
DQMHistoSizes: changed ( 25.0 ): ...
Checked 134 log files, 14 edm output root files, 32 DQM output files

mbluj · 2018-09-27T13:10:02Z

Hi,
I am not sure what is relation of the failed AddOn tests with changes proposed in this PR.
Concerning changes in DQM histogram sizes: they look in agreement with expectations - several histograms are removed by this PR.

mbluj · 2018-09-27T13:15:31Z

Closer inspection says that the tests failed due to problem with opening input files.

fabiocos · 2018-09-28T07:53:44Z

please test

cmsbuild · 2018-09-28T07:54:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30759/console Started: 2018/09/28 15:17

cmsbuild · 2018-09-28T16:46:33Z

+1
Tested at: 74a413a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24547/30759/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
74a413a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24547/30759/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24547/30759/git-merge-result

cmsbuild · 2018-09-28T16:46:36Z

Comparison job queued.

cmsbuild · 2018-09-28T18:30:01Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24547/30759/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2994306
DQMHistoTests: Total failures: 1580
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2992529
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -57864.697 KiB( 31 files compared)
DQMHistoSizes: changed ( 135.4,... ): -17.360 KiB RecoTauV/hpsPFTauProducerZMM_hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr3HitsdR03
DQMHistoSizes: changed ( 135.4,... ): -17.360 KiB RecoTauV/hpsPFTauProducerZEE_hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr3HitsdR03
DQMHistoSizes: changed ( 135.4,... ): -17.280 KiB RecoTauV/hpsPFTauProducerZEE_hpsPFTauDiscriminationByLooseCombinedIsolationDBSumPtCorr3HitsdR03
DQMHistoSizes: changed ( 135.4,... ): -17.280 KiB RecoTauV/hpsPFTauProducerZMM_hpsPFTauDiscriminationByTightCombinedIsolationDBSumPtCorr3HitsdR03
DQMHistoSizes: changed ( 135.4,... ): -17.280 KiB RecoTauV/hpsPFTauProducerZEE_hpsPFTauDiscriminationByTightCombinedIsolationDBSumPtCorr3HitsdR03
DQMHistoSizes: changed ( 135.4,... ): -17.280 KiB RecoTauV/hpsPFTauProducerZMM_hpsPFTauDiscriminationByLooseCombinedIsolationDBSumPtCorr3HitsdR03
DQMHistoSizes: changed ( 135.4,... ): -17.040 KiB RecoTauV/hpsPFTauProducerZEE_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1PWdR03oldDMwLT
DQMHistoSizes: changed ( 135.4,... ): -17.040 KiB RecoTauV/hpsPFTauProducerZTT_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1PWdR03oldDMwLT
DQMHistoSizes: changed ( 135.4,... ): -17.040 KiB RecoTauV/hpsPFTauProducerQCD_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1PWdR03oldDMwLT
DQMHistoSizes: changed ( 135.4,... ): -17.040 KiB RecoTauV/hpsPFTauProducerZMM_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1PWdR03oldDMwLT
DQMHistoSizes: changed ( 135.4 ): ...
Checked 134 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2018-10-10T20:07:50Z

+1

aspiezia and others added 8 commits August 28, 2018 17:24

plots for DQM tau

008af4a

plots for DQM tau - v2

8922edc

plots for DQM tau - v3

7f8c36a

plots for DQM tau - v4

5c2f8d4

plots for DQM tau - v5 - loops in range

b12f190

plots for DQM tau - v6 - const auto&

edf2db4

plots for DQM tau - v7 - tau multiplicity

0da3d21

Merge pull request #81 from aspiezia/CMSSW_10_3_X_tau_pog_DQMupdate

74a413a

plots for DQM tau

cmsbuild added this to the CMSSW_10_3_X milestone Sep 14, 2018

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Sep 14, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 14, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 19, 2018

cmsbuild removed the tests-started label Sep 19, 2018

cmsbuild added tests-rejected and removed tests-started labels Sep 27, 2018

cmsbuild added comparison-available and removed comparison-pending labels Sep 27, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-rejected labels Sep 28, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2018

cmsbuild added tests-approved and removed tests-started labels Sep 28, 2018

cmsbuild added comparison-available and removed comparison-pending labels Sep 28, 2018

smuzaffar modified the milestones: CMSSW_10_3_X, CMSSW_10_4_X Oct 10, 2018

cmsbuild added orp-approved and removed orp-pending labels Oct 10, 2018

cmsbuild merged commit d79bff4 into cms-sw:master Oct 10, 2018

mbluj deleted the CMSSW_10_3_X_tau_pog_DQMupdate branch October 10, 2023 10:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tau offline DQM update #24547

Tau offline DQM update #24547

mbluj commented Sep 14, 2018 •

edited

cmsbuild commented Sep 14, 2018

cmsbuild commented Sep 14, 2018

cmsbuild commented Sep 14, 2018

andrius-k commented Sep 17, 2018

mbluj commented Sep 17, 2018

andrius-k commented Sep 19, 2018

cmsbuild commented Sep 19, 2018 •

edited

andrius-k commented Sep 19, 2018

cmsbuild commented Sep 19, 2018

cmsbuild commented Sep 19, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

mbluj commented Sep 27, 2018

mbluj commented Sep 27, 2018

fabiocos commented Sep 28, 2018

cmsbuild commented Sep 28, 2018 •

edited

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

fabiocos commented Oct 10, 2018

Tau offline DQM update #24547

Tau offline DQM update #24547

Conversation

mbluj commented Sep 14, 2018 • edited

cmsbuild commented Sep 14, 2018

cmsbuild commented Sep 14, 2018

cmsbuild commented Sep 14, 2018

andrius-k commented Sep 17, 2018

mbluj commented Sep 17, 2018

andrius-k commented Sep 19, 2018

cmsbuild commented Sep 19, 2018 • edited

andrius-k commented Sep 19, 2018

cmsbuild commented Sep 19, 2018

cmsbuild commented Sep 19, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

mbluj commented Sep 27, 2018

mbluj commented Sep 27, 2018

fabiocos commented Sep 28, 2018

cmsbuild commented Sep 28, 2018 • edited

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

fabiocos commented Oct 10, 2018

mbluj commented Sep 14, 2018 •

edited

cmsbuild commented Sep 19, 2018 •

edited

cmsbuild commented Sep 28, 2018 •

edited