adding centrality to offline DQM/Physics for 2018 Heavy Ion run

[BetterWang]

adding centrality to offline DQM for 2018 Heavy Ion run

[BetterWang]

@mandrenguyen

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24553/6434

[cmsbuild]

A new Pull Request was created by @BetterWang (Quan Wang) for master.

It involves the following packages:

DQM/Physics

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@rappoccio this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[andrius-k]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30450/console Started: 2018/09/17 13:14

[andrius-k]

@BetterWang could you please make sure that there is a name of a subsystem in the title of the PR?

[cmsbuild]

-1

Tested at: 954f7ac

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24553/30450/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
158.0 step3

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO/step3_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24553/6449

[cmsbuild]

Pull request #24553 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

[andrius-k]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30459/console Started: 2018/09/17 16:38

[cmsbuild]

+1
Tested at: 9688abc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24553/30459/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24553/30459/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3146746
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3146547
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 127.223 KiB( 31 files compared)
• DQMHistoSizes: changed ( 158.0 ): 127.223 KiB Physics/Centrality
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[andrius-k]

@BetterWang could you please make sure that there is a name of a subsystem in the title of the PR? Then I will be able to sign it!

[BetterWang]

Hi @andrius-k , I updated the title to DQM/Physics, hope it is clear enough.

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[boudoul]

Thanks @andrius-k and @BetterWang to take care of PR titles! appreciated

[fabiocos]

+1