Hcal phase1 fastsim update and run2 hcx178 : backport to 94X

[ssekmen]

Backports of
#22990 : HCAL phase1 fastsim updates
#23631 : Run2-hcx178 Usage of the correct Hcal geometry in FastSim

[ssekmen]

please test

[cmsbuild]

A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_9_4_X.

It involves the following packages:

FastSimulation/CaloGeometryTools
FastSimulation/Calorimetry
FastSimulation/ShowerDevelopment
Geometry/HcalTowerAlgo
SimCalorimetry/HcalSimProducers
Validation/HcalDigis
Validation/HcalHits
Validation/HcalRecHits

@andrius-k, @Dr15Jones, @lveldere, @kmaeshima, @cvuosalo, @schneiml, @ssekmen, @mdhildreth, @ianna, @cmsbuild, @jfernan2, @civanch can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm, @mariadalfonso, @makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30437/console Started: 2018/09/16 22:56

[cmsbuild]

+1
Tested at: a3de45c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24559/30437/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24559/30437/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 4548
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2716783
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0

[ssekmen]

+1

[ianna]

+1

[ssekmen]

backport of #22990 and #23631

[andrius-k]

+1

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[ssekmen]

@kpedro88 , can you please merge this? Thanks.

[kpedro88]

+1