Bugfix: Remove TotemT2 Envelope Volume #24563

ianna · 2018-09-17T14:07:16Z

Add a forward:TotemT2 missing volume which is used in other files: ionpump.xml and castor.xml

ianna · 2018-09-17T14:07:25Z

please test

cmsbuild · 2018-09-17T14:07:36Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-09-17T14:10:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24563/6448

cmsbuild · 2018-09-17T14:10:30Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30458/console Started: 2018/09/17 16:10

cmsbuild · 2018-09-17T14:10:32Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Geometry/CMSCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

ianna · 2018-09-17T14:12:26Z

+1

The scenario is orthogonal to the production workflows and is not used in the relval tests.

cmsbuild · 2018-09-17T16:18:37Z

+1
Tested at: 885e125
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24563/30458/summary.html

cmsbuild · 2018-09-17T16:18:40Z

Comparison job queued.

civanch · 2018-09-17T16:53:08Z

@ianna , Totem2 has been removed for 2018 run physically, Castor not yet installed, it will be installed in November. It was discussed in the beginning of the year, that Totem2 is taken out but Castor geometry will be left, because Castor cannot affect central detector. If I understand correctly the description of this PR, then it would be better to close this PR.

cmsbuild · 2018-09-17T17:45:33Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24563/30458/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3146746
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3146548
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

ianna · 2018-09-18T08:24:25Z

@civanch - FYI, the included file does not define Totem, but the forward region. This scenario is (and must be) identical to 2018 with the exception of the detailed cavern and MB4 shields. It is needed for production asap which has been discussed and agreed at the PPD meeting.

cmsbuild · 2018-09-26T14:43:49Z

Pull request #24563 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

ianna · 2018-09-26T14:45:55Z

The latest commits added to remove the following warnings related to an incorrect definition of the Totem2 envelope volume:

WARNING: MCParticlePairFilter : size of some vectors not matching with 2!!
Cannot create Polycone with rInner > rOuter for the same Z
         rInner > rOuter for the same Z !
         rMin[2] = 3200 -- rMax[2] = 250Cannot create a Polycone with no 
contiguous segments.
                 Segments are not contiguous !
                 rMin[1] = 42 -- rMax[2] = 250
                 rMin[2] = 3200 -- rMax[1] = 250%MSG-w 
SimG4CoreApplication:  (NoModuleName) 19-Sep-2018 13:48:09 CEST pre-events

-------- WWWW ------- G4Exception-START -------- WWWW -------
*** G4Exception : GeomMgt0001
       issued by : G4UPolycone::BoundingLimits()
Inconsistency in bounding boxes for solid: TotemT2 !
BBox min: wrapper = (-3200,-3200,13381) solid = (-250, -250, 13381)
BBox max: wrapper = (3200,3200,15350) solid = (250, 250, 15350)*** This 
is just a warning message. ***
-------- WWWW -------- G4Exception-END --------- WWWW -------

and some other warnings about TotemT2...

ianna · 2018-09-26T14:46:03Z

please test

cmsbuild · 2018-09-26T14:46:12Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30660/console Started: 2018/09/26 17:49

ianna · 2018-09-26T14:46:30Z

+1

The scenario is orthogonal to the production workflows and is not used in the relval tests.

cmsbuild · 2018-09-26T17:46:06Z

+1
Tested at: 7177332
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24563/30660/summary.html

cmsbuild · 2018-09-26T17:46:09Z

Comparison job queued.

cmsbuild · 2018-09-26T19:05:45Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24563/30660/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3162160
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3161962
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

kpedro88 · 2018-09-27T16:15:16Z

+upgrade

cmsbuild · 2018-09-27T16:15:37Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-09-28T06:57:47Z

Geometry/CMSCommonData/data/cms/2018/v1/cms.xml

+ <Constant name="TotemBeamR5"  value="3.575*cm"/>
+ <Constant name="TotemBeamZ1"  value="7.9500*m"/>
+ <Constant name="TotemBeamZ2"  value="13.381*m"/>
+ <Constant name="TotemBeamZ3"  value="13.439*m"/>


@ianna @civanch does this and other lines imply that in 10_2_X we are using a wrong geometry description for the Fall18 production?

No, the changes are related to a wrongly defined envelope volume. It only produces G4 warnings.

fabiocos · 2018-09-28T06:58:25Z

Geometry/CMSCommonData/python/cmsExtendedGeometryDetailedCavern2018XML_cfi.py

@@ -239,10 +239,10 @@
        'Geometry/MuonCommonData/data/mfshield/2017/v1/mfshield.xml',
        'Geometry/MuonCommonData/data/gemf/TDR_BaseLine/gemf.xml',
        'Geometry/MuonCommonData/data/gem11/2017/v2/gem11.xml',
+        'Geometry/ForwardCommonData/data/forward/2018/v1/forward.xml',


@ianna @civanch the addition of CASTOR should be relevant only for HI data, right?

Yes. Unfortunately, there are some modules which ask for Castor hits in any case. Given that the production stops when they are not available, the easiest way was to keep it in the geometry description. The alternative would be to customize the producers, but it's not in my domain.

fabiocos · 2018-09-28T06:58:52Z

Geometry/CMSCommonData/python/cmsExtendedGeometryDetailedCavern2018XML_cfi.py

        'Geometry/ForwardCommonData/data/forwardshield/2017/v1/forwardshield.xml',
        'Geometry/ForwardCommonData/data/brmrotations.xml',
        'Geometry/ForwardCommonData/data/PostLS2/brm.xml',
-        'Geometry/ForwardCommonData/data/ionpump.xml',


@ianna @civanch is this material that will be removed now?

fabiocos · 2018-09-28T06:59:15Z

@ianna although this is for 10_3_X (to be used for HI data taking), could you please clarify the possible implications of this PR for 10_2_X ongoing SIM production? Are we using a wrong geometry configuration there?

ianna · 2018-09-28T10:32:12Z

@fabiocos - If the 10_2_X production is ongoing, there should be no problem. This PR is for an alternative scenario.

civanch · 2018-09-28T10:39:38Z

@fabiocos , we discuss at spring, that TOTEM1,2 detectors are physically dismantled forever and Castor should be installed in November, so we take away TOTEM from production of 2018 but leave Castor in in order to have uniform simulation for whole year. Physically any particle entering Castor will never reflected back in our simulation, CPU overhead due to Castor is minimal. These were arguments to keep Castor.

fabiocos · 2018-09-28T13:42:14Z

+1

Add missing volumes which are referred to from other files

885e125

cmsbuild added this to the CMSSW_10_3_X milestone Sep 17, 2018

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Sep 17, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 17, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 17, 2018

cmsbuild added geometry-approved and removed geometry-pending labels Sep 17, 2018

cmsbuild added tests-approved and removed tests-started labels Sep 17, 2018

cmsbuild added comparison-available and removed comparison-pending labels Sep 17, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 26, 2018

cmsbuild added geometry-approved and removed geometry-pending labels Sep 26, 2018

cmsbuild added tests-approved and removed tests-started labels Sep 26, 2018

cmsbuild added comparison-available and removed comparison-pending labels Sep 26, 2018

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Sep 27, 2018

fabiocos reviewed Sep 28, 2018

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Sep 28, 2018

cmsbuild merged commit 688da1d into cms-sw:master Sep 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix: Remove TotemT2 Envelope Volume #24563

Bugfix: Remove TotemT2 Envelope Volume #24563

ianna commented Sep 17, 2018 •

edited

ianna commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 17, 2018 •

edited

cmsbuild commented Sep 17, 2018

ianna commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

civanch commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

ianna commented Sep 18, 2018 •

edited

cmsbuild commented Sep 26, 2018

ianna commented Sep 26, 2018

ianna commented Sep 26, 2018

cmsbuild commented Sep 26, 2018 •

edited

ianna commented Sep 26, 2018

cmsbuild commented Sep 26, 2018

cmsbuild commented Sep 26, 2018

cmsbuild commented Sep 26, 2018

kpedro88 commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

fabiocos Sep 28, 2018

ianna Sep 28, 2018

fabiocos Sep 28, 2018

ianna Sep 28, 2018

fabiocos Sep 28, 2018

fabiocos commented Sep 28, 2018

ianna commented Sep 28, 2018

civanch commented Sep 28, 2018

fabiocos commented Sep 28, 2018

Bugfix: Remove TotemT2 Envelope Volume #24563

Bugfix: Remove TotemT2 Envelope Volume #24563

Conversation

ianna commented Sep 17, 2018 • edited

ianna commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 17, 2018 • edited

cmsbuild commented Sep 17, 2018

ianna commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

civanch commented Sep 17, 2018

cmsbuild commented Sep 17, 2018

ianna commented Sep 18, 2018 • edited

cmsbuild commented Sep 26, 2018

ianna commented Sep 26, 2018

ianna commented Sep 26, 2018

cmsbuild commented Sep 26, 2018 • edited

ianna commented Sep 26, 2018

cmsbuild commented Sep 26, 2018

cmsbuild commented Sep 26, 2018

cmsbuild commented Sep 26, 2018

kpedro88 commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

fabiocos Sep 28, 2018

Choose a reason for hiding this comment

ianna Sep 28, 2018

Choose a reason for hiding this comment

fabiocos Sep 28, 2018

Choose a reason for hiding this comment

ianna Sep 28, 2018

Choose a reason for hiding this comment

fabiocos Sep 28, 2018

Choose a reason for hiding this comment

fabiocos commented Sep 28, 2018

ianna commented Sep 28, 2018

civanch commented Sep 28, 2018

fabiocos commented Sep 28, 2018

ianna commented Sep 17, 2018 •

edited

cmsbuild commented Sep 17, 2018 •

edited

ianna commented Sep 18, 2018 •

edited

cmsbuild commented Sep 26, 2018 •

edited