Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tested new configuration that works for HI runs #24572

Merged
merged 1 commit into from Sep 26, 2018
Merged

Tested new configuration that works for HI runs #24572

merged 1 commit into from Sep 26, 2018

Conversation

dinardo
Copy link
Contributor

@dinardo dinardo commented Sep 17, 2018

I updated the tracking configuration as in here:
http://cmslxr.fnal.gov/source/RecoVertex/PrimaryVertexProducer/python/OfflinePrimaryVertices_cfi.py

Now the application is able to read and process HI data.

  • Mauro.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dinardo (Mauro) for CMSSW_10_2_X.

It involves the following packages:

DQM/Integration

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@makortel, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

not testing really much...

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 18, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30476/console Started: 2018/09/18 14:36

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24572/30476/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2985426
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2985234
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@dinardo @andrius-k sorry, is this updated supposed to be valid only for HI?

@andrius-k
Copy link

@fabiocos I'm not sure about this. @dinardo Maybe you can elaborate?

@dinardo
Copy link
Contributor Author

dinardo commented Sep 25, 2018

No no. It's valid for any kind of run.
There is check in the code: process.runType.getRunType
So it's good for any kind of data taking.

@fabiocos
Copy link
Contributor

@dinardo right, but some settings were moved before the checks, I was wondering about that

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6574a0b into cms-sw:CMSSW_10_2_X Sep 26, 2018
@dinardo
Copy link
Contributor Author

dinardo commented Sep 26, 2018

Hi,
yes you are correct. But they are common to all run-type.

Is this going to go to the master branch or I need to push a new PR specifically for the master branch?

Cheers,

  • Mauro.

@fabiocos
Copy link
Contributor

@dinardo my bad, I overlooked the fact that this is not a backport. Please do asap a master version corresponding to this code

@dinardo
Copy link
Contributor Author

dinardo commented Sep 26, 2018

Hi, which CMSSW verison shall I use to push the changed into the master?

  • Mauro.

@fabiocos
Copy link
Contributor

@dinardo you need to be based on 10_3_X, to which master points

@dinardo
Copy link
Contributor Author

dinardo commented Sep 26, 2018

OK, done in CMSSW_10_3_X as you suggested:
PR #24679

  • Mauro.

fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Oct 8, 2020
Tested new configuration that works for HI runs
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Oct 19, 2020
Tested new configuration that works for HI runs
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Oct 20, 2020
Tested new configuration that works for HI runs
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Oct 23, 2020
Tested new configuration that works for HI runs
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Nov 6, 2020
Tested new configuration that works for HI runs
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Nov 16, 2020
Tested new configuration that works for HI runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants