Add new scenarios for HPBeamspot in ExpressAlignment HcalCalMinBias in HCalNZS PD #24573

tocheng · 2018-09-18T13:30:58Z

Hello all,

The PR introduces two new scenarios for Tier-0 to process HPBeamspot and HcalCalMinBias for heavyIon 2018 run in Run2_2018_pp_on_AA.

The new scenarios could be tested using the recent Heavy Ion test runs.

…nBias in HcaNZS PD

cmsbuild · 2018-09-18T13:31:15Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-09-18T13:33:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24573/6466

cmsbuild · 2018-09-18T13:33:23Z

A new Pull Request was created by @tocheng (Tongguang) for master.

It involves the following packages:

Configuration/DataProcessing

@cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

tocheng · 2018-09-18T13:36:16Z

@franzoni @cerminar This is something you want to follow. Thanks.

tocheng · 2018-09-18T13:36:25Z

please test

cmsbuild · 2018-09-18T13:36:35Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30477/console Started: 2018/09/18 15:37

slava77 · 2018-09-18T13:44:40Z

Configuration/DataProcessing/python/Impl/hcalnzsEra_Run2_2018_pp_on_AA.py

+from Configuration.DataProcessing.Impl.hcalnzs import hcalnzs
+from Configuration.Eras.Era_Run2_2018_pp_on_AA_cff import Run2_2018_pp_on_AA
+
+class hcalnzsEra_Run2_2018_highBetaStar(hcalnzs):


the name is incorrect

fixed in last commit

slava77 · 2018-09-18T13:46:57Z

Configuration/DataProcessing/python/Impl/hcalnzsEra_Run2_2018_pp_on_AA.py

+        hcalnzs.__init__(self)
+        self.recoSeq=':reconstruction_HcalNZS'
+        self.cbSc='pp'
+        self.addEI=True


apparently the 3 lines above are superfluous, they somehow sneaked in through copy-paste from old scenarios

removed in last commit

slava77 · 2018-09-18T13:47:02Z

Configuration/DataProcessing/python/Impl/hcalnzsEra_Run2_2018_pp_on_AA.py

+        #keep post-era parts the same as in the default 2018 era
+        self.promptCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018' ]
+        self.expressCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018' ]
+        self.visCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018' ]


please use the same customs as in ppEra_Run2_2018_pp_on_AA.py
customisePostEra_Run2_2018_pp_on_AA

changed to use customisePostEra_Run2_2018_pp_on_AA in the last commit

slava77 · 2018-09-18T13:47:40Z

Configuration/DataProcessing/python/Impl/trackingOnlyEra_Run2_2018_pp_on_AA.py

+        #keep post-era parts the same as in the default 2018 era
+        self.promptCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018' ]
+        self.expressCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018_express_trackingOnly' ]
+        self.visCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018' ]


customs, as in hcalnzs, please use what's in ppEra

changed to use customisePostEra_Run2_2018_pp_on_AA

slava77 · 2018-09-18T13:48:56Z

please add the new scenarios to Configuration/DataProcessing/test/run_CfgTest.sh

tocheng · 2018-09-18T13:52:48Z

please abort

cmsbuild · 2018-09-18T13:53:09Z

Jenkins tests are aborted.

… superfluous class initialization; add two scenarios to Configuration/DataProcessing/test/run_CfgTest.sh

cmsbuild · 2018-09-18T14:11:04Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-09-18T14:12:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24573/6467

cmsbuild · 2018-09-20T13:19:23Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-09-20T13:21:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24573/6497

cmsbuild · 2018-09-20T13:21:28Z

Pull request #24573 was updated. @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please check and sign again.

tocheng · 2018-09-20T13:48:43Z

please test

cmsbuild · 2018-09-20T13:49:02Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30530/console Started: 2018/09/20 16:25

cmsbuild · 2018-09-20T16:36:33Z

+1
Tested at: 94438a8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24573/30530/summary.html

cmsbuild · 2018-09-20T16:36:37Z

Comparison job queued.

cmsbuild · 2018-09-20T17:55:31Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24573/30530/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3146746
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3146546
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2018-09-22T21:57:15Z

+1

cmsbuild · 2018-09-22T21:57:36Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

add new scenarios for HPBeamspot in ExpressAlignment PD and HcalCalMi…

83652aa

…nBias in HcaNZS PD

cmsbuild added this to the CMSSW_10_3_X milestone Sep 18, 2018

cmsbuild added code-checks-pending comparison-pending operations-pending orp-pending pending-signatures tests-pending labels Sep 18, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 18, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 18, 2018

tocheng mentioned this pull request Sep 18, 2018

Add new scenarios for HPBeamspot in ExpressAlignment HcalCalMinBias in HCalNZS PD #24574

Closed

slava77 reviewed Sep 18, 2018

View reviewed changes

cmsbuild added tests-pending and removed tests-started labels Sep 18, 2018

fix class name error, use customisePostEra_Run2_2018_pp_on_AA, remove…

4527e7e

… superfluous class initialization; add two scenarios to Configuration/DataProcessing/test/run_CfgTest.sh

cmsbuild added code-checks-pending and removed code-checks-approved labels Sep 18, 2018

cmsbuild added code-checks-pending comparison-pending tests-pending and removed comparison-available tests-approved labels Sep 20, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 20, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 20, 2018

cmsbuild added tests-approved and removed tests-started labels Sep 20, 2018

cmsbuild added comparison-available and removed comparison-pending labels Sep 20, 2018

cmsbuild added fully-signed operations-approved orp-approved and removed operations-pending orp-pending pending-signatures labels Sep 22, 2018

cmsbuild merged commit 5b3bbab into cms-sw:master Sep 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new scenarios for HPBeamspot in ExpressAlignment HcalCalMinBias in HCalNZS PD #24573

Add new scenarios for HPBeamspot in ExpressAlignment HcalCalMinBias in HCalNZS PD #24573

tocheng commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

tocheng commented Sep 18, 2018 •

edited

tocheng commented Sep 18, 2018

cmsbuild commented Sep 18, 2018 •

edited

slava77 Sep 18, 2018

tocheng Sep 18, 2018

slava77 Sep 18, 2018

tocheng Sep 18, 2018

slava77 Sep 18, 2018

tocheng Sep 18, 2018

slava77 Sep 18, 2018

tocheng Sep 18, 2018

slava77 commented Sep 18, 2018

tocheng commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 20, 2018

cmsbuild commented Sep 20, 2018

cmsbuild commented Sep 20, 2018

tocheng commented Sep 20, 2018

cmsbuild commented Sep 20, 2018 •

edited

cmsbuild commented Sep 20, 2018

cmsbuild commented Sep 20, 2018

cmsbuild commented Sep 20, 2018

fabiocos commented Sep 22, 2018

cmsbuild commented Sep 22, 2018

Add new scenarios for HPBeamspot in ExpressAlignment HcalCalMinBias in HCalNZS PD #24573

Add new scenarios for HPBeamspot in ExpressAlignment HcalCalMinBias in HCalNZS PD #24573

Conversation

tocheng commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

tocheng commented Sep 18, 2018 • edited

tocheng commented Sep 18, 2018

cmsbuild commented Sep 18, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slava77 commented Sep 18, 2018

tocheng commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 18, 2018

cmsbuild commented Sep 20, 2018

cmsbuild commented Sep 20, 2018

cmsbuild commented Sep 20, 2018

tocheng commented Sep 20, 2018

cmsbuild commented Sep 20, 2018 • edited

cmsbuild commented Sep 20, 2018

cmsbuild commented Sep 20, 2018

cmsbuild commented Sep 20, 2018

fabiocos commented Sep 22, 2018

cmsbuild commented Sep 22, 2018

tocheng commented Sep 18, 2018 •

edited

cmsbuild commented Sep 18, 2018 •

edited

cmsbuild commented Sep 20, 2018 •

edited