Ecal Transparency corrections : use either a tag or a file for TPG #24603
Conversation
…rameters building
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24603/6493 |
|
A new Pull Request was created by @depasse for master. It involves the following packages: CalibCalorimetry/EcalTPGTools @cmsbuild, @tocheng, @nsmith-, @rekovic, @franzoni, @thomreis, @pohsun, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
| edm::LogInfo("TopInfo") << ss.str(); | ||
| ss.str(""); | ||
| } // file | ||
| else { // Jean 2018 |
There was a problem hiding this comment.
@depasse as far as I understand, this option is so far dummy, and just activated in the test configurationa dded to this PR
There was a problem hiding this comment.
This is a new feature very convenient to be able to upload payloads
from sqlite files without the need to convert them to xml or txt ones.
It is neither dummy nor for test only.
There was a problem hiding this comment.
@depasse I mean that so far there is no configuration activating it in production. Do you confirm?
There was a problem hiding this comment.
Yes, it is not triggered in production. It is in EcalTPG"Tools" and will be used in the future ponctually. It is important to keep the traceability of this.
|
+1 |
When building Ecal TPG parameters, allows to use either a file or a tag for the Transparency corrections (before, only files were allowed)