Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eta range plots for pixel Phase1 #24614

Merged
merged 1 commit into from Sep 21, 2018

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Sep 21, 2018

bug-fix

@mtosi
Copy link
Contributor Author

mtosi commented Sep 21, 2018

during recent condition validation,
I realized there are some tracking plots vs eta which have the wrong range (still phase0)
for instance : https://goo.gl/nnX1Qv

@cmsbuild cmsbuild added this to the CMSSW_10_3_X milestone Sep 21, 2018
@mtosi
Copy link
Contributor Author

mtosi commented Sep 21, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 21, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30542/console Started: 2018/09/21 11:59

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

DQMOffline/RecoB

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@swertz, @imarches, @smoortga, @acaudron, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@mtosi mtosi changed the title fix eta range plots for Phase1 fix eta range plots for pixel Phase1 Sep 21, 2018
@mtosi
Copy link
Contributor Author

mtosi commented Sep 21, 2018

@davidlange6, @slava77, @fabiocos why I do not see the "bug fix" tag in the list ?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24614/30542/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3146746
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 48
  • DQMHistoTests: Total successes: 3146499
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 5.781 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 136.85,... ): 0.469 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 136.85,... ): 0.156 KiB OfflinePV/Alignment
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 703b485 into cms-sw:master Sep 21, 2018
cmsbuild added a commit that referenced this pull request Sep 25, 2018
fix eta range plots for pixel Phase1 [backport #24614]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants