Allow PluginDescription default to work in release build #24656
Conversation
Added a configuration option to allow the PluginManager to not throw an exception in the case where it can not find any edmplugincache files.
When building a release, the construction of the final edmplugcache file does not happen until the very end of the build. This is after running edmWriteConfigs which can cause the cfi generation to fail. For now, default user plugins must be linked in with the module using them as a default.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24656/6569 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cmsbuild
added
core-approved
fully-signed
tests-started
and removed
core-pending
pending-signatures
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 based on Chris' tests, let's verify whether next IB is fixed (checks to be looked at anyway) |
|
merge |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@Dr15Jones @smuzaffar the build problem looks solved, and the differences observed in the comparison look to me related to other PRs merged in the meanwhile (L1T, ECAL) |
|
@fabiocos I agree that the differences are unrelated to this pull request. |
The use of a default user plugin type with PluginDescription was failing when doing a full release build because it was requiring the global .edmplugincache file to already exist.
This pull request removes that requirement.