DQMOffline/RecoB: replace bind2nd with equivalent lambda #24700

gartung · 2018-09-27T15:31:20Z

bind2nd is remove for std=c++17

…remove for std=c++17.

cmsbuild · 2018-09-27T15:31:40Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-09-27T15:34:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24700/6635

cmsbuild · 2018-09-27T15:34:21Z

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

DQMOffline/RecoB

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@swertz, @imarches, @smoortga, @acaudron, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

andrius-k · 2018-09-28T12:45:59Z

+1

cmsbuild · 2018-09-28T12:46:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30766/console Started: 2018/09/28 16:16

cmsbuild · 2018-09-28T12:46:18Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2018-09-28T16:58:41Z

-1

Tested at: 081722e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24700/30766/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake2 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Fri Sep 28 18:28:35 2018-date Fri Sep 28 18:27:53 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:28:35 2018-date Fri Sep 28 18:27:53 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:28:35 2018-date Fri Sep 28 18:27:53 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 18:28:48 2018-date Fri Sep 28 18:27:56 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:28:48 2018-date Fri Sep 28 18:27:56 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:28:48 2018-date Fri Sep 28 18:27:56 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full2015Data --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Fri Sep 28 18:28:42 2018-date Fri Sep 28 18:28:01 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:28:42 2018-date Fri Sep 28 18:28:01 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:28:42 2018-date Fri Sep 28 18:28:01 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 18:33:10 2018-date Fri Sep 28 18:28:54 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:33:10 2018-date Fri Sep 28 18:28:54 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:33:10 2018-date Fri Sep 28 18:28:54 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_2018v35 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_2018v35_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 18:35:51 2018-date Fri Sep 28 18:32:58 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_2018v35.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:35:51 2018-date Fri Sep 28 18:32:58 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:2018v35,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2018v35 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018v35_DATA.root --fileout file:RelVal_Raw_2018v35_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:35:51 2018-date Fri Sep 28 18:32:58 2018 s - exit: 21504
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py : FAILED - time: date Fri Sep 28 18:35:48 2018-date Fri Sep 28 18:35:32 2018 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Fri Sep 28 18:37:24 2018-date Fri Sep 28 18:35:53 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:37:24 2018-date Fri Sep 28 18:35:53 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:37:24 2018-date Fri Sep 28 18:35:53 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 18:38:02 2018-date Fri Sep 28 18:35:54 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:38:02 2018-date Fri Sep 28 18:35:54 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:38:02 2018-date Fri Sep 28 18:35:54 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:GCTGT --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake1 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Fri Sep 28 18:38:17 2018-date Fri Sep 28 18:37:27 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:38:17 2018-date Fri Sep 28 18:37:27 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:38:17 2018-date Fri Sep 28 18:37:27 2018 s - exit: 21504

cmsbuild · 2018-09-28T16:58:43Z

Comparison job queued.

gartung · 2018-09-28T17:18:45Z

Error opening file on EOS because of missing/expired authentication.
@Dr15Jones please retest.

Dr15Jones · 2018-09-28T17:37:47Z

Please test

cmsbuild · 2018-10-01T11:26:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30814/console Started: 2018/10/01 13:26

Dr15Jones · 2018-10-01T13:25:37Z

please test

cmsbuild · 2018-10-01T13:25:57Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30821/console Started: 2018/10/01 15:26

cmsbuild · 2018-10-01T16:02:15Z

+1
Tested at: 081722e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24700/30821/summary.html

cmsbuild · 2018-10-01T16:02:18Z

Comparison job queued.

cmsbuild · 2018-10-01T17:39:48Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24700/30821/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3162800
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3162601
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2018-10-02T08:37:49Z

@jfernan2 @andrius-k could you please check it again?

jfernan2 · 2018-10-03T07:18:23Z

+1

cmsbuild · 2018-10-03T07:18:40Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-10-03T16:01:37Z

+1

DQMOffline/RecoB: replace bind2nd with equivalent lambda; bind2nd is …

081722e

…remove for std=c++17.

cmsbuild added this to the CMSSW_10_3_X milestone Sep 27, 2018

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Sep 27, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 27, 2018

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Sep 28, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2018

cmsbuild added tests-rejected and removed tests-started labels Sep 28, 2018

cmsbuild added tests-pending and removed tests-rejected labels Sep 28, 2018

cmsbuild added comparison-pending tests-pending labels Oct 1, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 1, 2018

cmsbuild added tests-pending tests-started and removed tests-started tests-pending labels Oct 1, 2018

cmsbuild added tests-approved and removed tests-started labels Oct 1, 2018

cmsbuild added comparison-available and removed comparison-pending labels Oct 1, 2018

cmsbuild added dqm-approved fully-signed and removed dqm-rejected pending-signatures labels Oct 3, 2018

cmsbuild added orp-approved and removed orp-pending labels Oct 3, 2018

cmsbuild merged commit 8725e89 into cms-sw:master Oct 3, 2018

gartung deleted the DQMOffline-RecoB-strictcxx17 branch November 5, 2018 15:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DQMOffline/RecoB: replace bind2nd with equivalent lambda #24700

DQMOffline/RecoB: replace bind2nd with equivalent lambda #24700

gartung commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

andrius-k commented Sep 28, 2018

cmsbuild commented Sep 28, 2018 •

edited

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

gartung commented Sep 28, 2018

Dr15Jones commented Sep 28, 2018

cmsbuild commented Oct 1, 2018 •

edited

Dr15Jones commented Oct 1, 2018

cmsbuild commented Oct 1, 2018 •

edited

cmsbuild commented Oct 1, 2018

cmsbuild commented Oct 1, 2018

cmsbuild commented Oct 1, 2018

fabiocos commented Oct 2, 2018

jfernan2 commented Oct 3, 2018

cmsbuild commented Oct 3, 2018

fabiocos commented Oct 3, 2018

DQMOffline/RecoB: replace bind2nd with equivalent lambda #24700

DQMOffline/RecoB: replace bind2nd with equivalent lambda #24700

Conversation

gartung commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

andrius-k commented Sep 28, 2018

cmsbuild commented Sep 28, 2018 • edited

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

gartung commented Sep 28, 2018

Dr15Jones commented Sep 28, 2018

cmsbuild commented Oct 1, 2018 • edited

Dr15Jones commented Oct 1, 2018

cmsbuild commented Oct 1, 2018 • edited

cmsbuild commented Oct 1, 2018

cmsbuild commented Oct 1, 2018

cmsbuild commented Oct 1, 2018

fabiocos commented Oct 2, 2018

jfernan2 commented Oct 3, 2018

cmsbuild commented Oct 3, 2018

fabiocos commented Oct 3, 2018

cmsbuild commented Sep 28, 2018 •

edited

cmsbuild commented Oct 1, 2018 •

edited

cmsbuild commented Oct 1, 2018 •

edited