Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make shape_ a static const member of CastorQIEData #2473

Merged
merged 1 commit into from Feb 17, 2014
Merged

make shape_ a static const member of CastorQIEData #2473

merged 1 commit into from Feb 17, 2014

Conversation

gartung
Copy link
Member

@gartung gartung commented Feb 14, 2014

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_1_X.

make shape_ a static const member of CastorQIEData

It involves the following packages:

CondFormats/CastorObjects

@apfeiffer1, @diguida, @cmsbuild, @nclopezo, @rcastello, @ggovi, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor

diguida commented Feb 14, 2014

+1
Provided Jenkins agrees.
@gartung you also refreshed my cache on how to initialize a static const member correctly in the .cc file ;-)

@apfeiffer1
Copy link
Contributor

+1

On Fri, Feb 14, 2014 at 5:51 PM, Salvatore Di Guida <
notifications@github.com> wrote:

+1
Provided Jenkins agrees.
@gartung https://github.com/gartung you also refreshed my cache on how
to initialize a static const member correctly in the .cc file ;-)

Reply to this email directly or view it on GitHubhttps://github.com//pull/2473#issuecomment-35101621
.

Thanks,
cheers, andreas

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2473/188/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@Dr15Jones
Copy link
Contributor

This is an unrelated DAS failure. @nclopezo David, please rerun the tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Feb 17, 2014
…cs-work-2

CondFormats/CastorObjects -- make shape_ a static const member of CastorQIEData
@nclopezo nclopezo merged commit 1d59ead into cms-sw:CMSSW_7_1_X Feb 17, 2014
@gartung gartung deleted the CondFormats-CastorObjects-statics-work-2 branch February 19, 2014 17:18
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Update data-SLHCUpgradeSimulations-Geometry.spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants