RecoTauTag/RecoTau: replace functions and templates removed by stict std=c++17(where possible). #24741

gartung · 2018-09-27T17:44:32Z

replace bind2nd with equivalent lambda function
replace auto_ptr with unique_ptr where possible
Until boost is moved to 1.67 the basis of ptr_vector and ptr_list is std::auto_ptr. The remaining auto_ptr in this package can be changed to unique_ptr then,

…std=c++17 (where possible).

cmsbuild · 2018-09-27T17:44:50Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-09-27T17:46:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24741/6679

cmsbuild · 2018-09-27T17:46:52Z

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

RecoTauTag/RecoTau

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

slava77 · 2018-09-27T19:51:37Z

@cmsbuild please test

cmsbuild · 2018-09-27T19:53:41Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30738/console Started: 2018/09/28 03:15

cmsbuild · 2018-09-28T03:57:49Z

-1

Tested at: dcfe200

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6cb583d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24741/30738/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24741/30738/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24741/30738/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.788 step2

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step2_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake2 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Fri Sep 28 05:32:39 2018-date Fri Sep 28 05:31:59 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 05:32:39 2018-date Fri Sep 28 05:31:59 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 05:32:39 2018-date Fri Sep 28 05:31:59 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 05:32:53 2018-date Fri Sep 28 05:32:03 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 05:32:53 2018-date Fri Sep 28 05:32:03 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 05:32:53 2018-date Fri Sep 28 05:32:03 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full2015Data --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Fri Sep 28 05:32:46 2018-date Fri Sep 28 05:32:07 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 05:32:46 2018-date Fri Sep 28 05:32:07 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 05:32:46 2018-date Fri Sep 28 05:32:07 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 05:37:16 2018-date Fri Sep 28 05:32:59 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 05:37:16 2018-date Fri Sep 28 05:32:59 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 05:37:16 2018-date Fri Sep 28 05:32:59 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_2018v35 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_2018v35_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 05:40:42 2018-date Fri Sep 28 05:37:15 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2018v35.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 05:40:42 2018-date Fri Sep 28 05:37:15 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:2018v35,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2018v35 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018v35_DATA.root --fileout file:RelVal_Raw_2018v35_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 05:40:42 2018-date Fri Sep 28 05:37:15 2018 s - exit: 21504
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-1100/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py : FAILED - time: date Fri Sep 28 05:40:23 2018-date Fri Sep 28 05:40:09 2018 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Fri Sep 28 05:41:41 2018-date Fri Sep 28 05:40:32 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 05:41:41 2018-date Fri Sep 28 05:40:32 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 05:41:41 2018-date Fri Sep 28 05:40:32 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 05:42:30 2018-date Fri Sep 28 05:40:47 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 05:42:30 2018-date Fri Sep 28 05:40:47 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 05:42:30 2018-date Fri Sep 28 05:40:47 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:GCTGT --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake1 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Fri Sep 28 05:42:41 2018-date Fri Sep 28 05:41:49 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 05:42:41 2018-date Fri Sep 28 05:41:49 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 05:42:41 2018-date Fri Sep 28 05:41:49 2018 s - exit: 21504

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6cb583d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24741/30738/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24741/30738/git-merge-result

cmsbuild · 2018-09-28T03:57:51Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

gartung · 2018-09-28T04:11:04Z

File input open failures because of missing authentication.

perrotta · 2018-09-28T06:49:18Z

@cmsbuild please test
(retry...)

cmsbuild · 2018-09-28T06:49:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30754/console Started: 2018/09/28 13:51

cmsbuild · 2018-09-28T19:55:35Z

The code-checks are being triggered in jenkins.

slava77 · 2018-09-28T19:56:50Z

@cmsbuild please test

cmsbuild · 2018-09-28T19:57:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24741/6704

cmsbuild · 2018-09-28T19:57:29Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30795/console Started: 2018/09/28 22:38

cmsbuild · 2018-09-28T19:57:31Z

Pull request #24741 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

cmsbuild · 2018-09-28T23:15:05Z

+1
Tested at: c53b2b7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24741/30795/summary.html

cmsbuild · 2018-09-28T23:15:07Z

Comparison job queued.

cmsbuild · 2018-09-29T02:44:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24741/30795/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3162160
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3161961
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

slava77 · 2018-09-30T09:19:14Z

+1

for #24741 c53b2b7

technical
jenkins tests pass and comparisons now show no differences

cmsbuild · 2018-09-30T09:19:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-10-01T11:51:17Z

+1

RecoTauTag/RecoTau: replace functions and templates removed by stict …

dcfe200

…std=c++17 (where possible).

cmsbuild added this to the CMSSW_10_3_X milestone Sep 27, 2018

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 27, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 27, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 27, 2018

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Sep 28, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Sep 28, 2018

cmsbuild added the tests-pending label Sep 28, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 28, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2018

cmsbuild added tests-approved and removed tests-started labels Sep 28, 2018

cmsbuild added comparison-available and removed comparison-pending labels Sep 29, 2018

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Sep 30, 2018

cmsbuild added orp-approved and removed orp-pending labels Oct 1, 2018

cmsbuild merged commit a5bee72 into cms-sw:master Oct 1, 2018

slava77 mentioned this pull request Oct 1, 2018

Tau reconstruction based on miniAOD event content #22594

Merged

mbluj mentioned this pull request Oct 2, 2018

Synchnronize with 10_3_X cms-tau-pog/cmssw#90

Merged

gartung deleted the RecoTauTagRecoTau-strictcxx17 branch November 5, 2018 15:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RecoTauTag/RecoTau: replace functions and templates removed by stict std=c++17(where possible). #24741

RecoTauTag/RecoTau: replace functions and templates removed by stict std=c++17(where possible). #24741

gartung commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

slava77 commented Sep 27, 2018

cmsbuild commented Sep 27, 2018 •

edited

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

gartung commented Sep 28, 2018

perrotta commented Sep 28, 2018

cmsbuild commented Sep 28, 2018 •

edited

cmsbuild commented Sep 28, 2018

slava77 commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018 •

edited

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 29, 2018

slava77 commented Sep 30, 2018

cmsbuild commented Sep 30, 2018

fabiocos commented Oct 1, 2018

RecoTauTag/RecoTau: replace functions and templates removed by stict std=c++17(where possible). #24741

RecoTauTag/RecoTau: replace functions and templates removed by stict std=c++17(where possible). #24741

Conversation

gartung commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

slava77 commented Sep 27, 2018

cmsbuild commented Sep 27, 2018 • edited

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

gartung commented Sep 28, 2018

perrotta commented Sep 28, 2018

cmsbuild commented Sep 28, 2018 • edited

cmsbuild commented Sep 28, 2018

slava77 commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018 • edited

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 29, 2018

slava77 commented Sep 30, 2018

cmsbuild commented Sep 30, 2018

fabiocos commented Oct 1, 2018

cmsbuild commented Sep 27, 2018 •

edited

cmsbuild commented Sep 28, 2018 •

edited

cmsbuild commented Sep 28, 2018 •

edited