Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for concurrent IOVs, MisalignedMuonESProducer #24746

Merged

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Sep 27, 2018

Change produced type from shared_ptr to unique_ptr.

Note this required changing the arguments to the
GeometryBuilders build functions to just be simple
references which is better anyway because the old
interface restricted the caller to using shared_ptr
for no reason.

Change produced type from shared_ptr to unique_ptr.

Note this required changing the arguments to the
GeometryBuilders build functions to just be simple
references which is better anyway because the old
interface restricted the caller to using shared_ptr
for no reason.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

Alignment/CommonAlignmentMonitor
Alignment/CommonAlignmentProducer
Alignment/MuonAlignment
Geometry/CSCGeometryBuilder
Geometry/DTGeometryBuilder

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@pakhotin, @abbiendi, @jhgoh, @ptcox, @tocheng, @tlampen, @mschrode, @mmusich, @trocino this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@wddgit
Copy link
Contributor Author

wddgit commented Sep 27, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 27, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30734/console Started: 2018/09/28 02:26

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24746/30734/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162160
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3161962
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@ianna
Copy link
Contributor

ianna commented Sep 28, 2018

+1

@pohsun
Copy link

pohsun commented Oct 1, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar modified the milestones: CMSSW_10_3_X, CMSSW_10_4_X Oct 10, 2018
@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 497653c into cms-sw:master Oct 11, 2018
@wddgit wddgit deleted the concurrentIOVsMisalignedMuonESProducer branch January 14, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants