New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for concurrent IOVs, MisalignedMuonESProducer #24746
Prepare for concurrent IOVs, MisalignedMuonESProducer #24746
Conversation
Change produced type from shared_ptr to unique_ptr. Note this required changing the arguments to the GeometryBuilders build functions to just be simple references which is better anyway because the old interface restricted the caller to using shared_ptr for no reason.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24746/6685 |
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: Alignment/CommonAlignmentMonitor @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @pohsun, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Change produced type from shared_ptr to unique_ptr.
Note this required changing the arguments to the
GeometryBuilders build functions to just be simple
references which is better anyway because the old
interface restricted the caller to using shared_ptr
for no reason.