made double em enrichment filter parameters tracked

[andreh7]

as a follow-up to #22980, this pull request has the following changes:

• removed unused parameter maxEvents (still existed but was -- apart from a warning message -- ignored)
• made physics related parameters in PythiaHepMCFilterGammaGamma tracked parameters (these were untracked before)
• added parameter descriptions in =PythiaHepMCFilterGammaGamma.h= (and more comments on the algorithm in =PythiaHepMCFilterGammaGamma.cc=). I was considering implementing = fillDescriptions()= but since this filter does not inherit from =EDFilter= this method would not be used as far as I understood.

(mentioning @pgrash since he may be interested in seeing how this pull request progresses).

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24754/6698

[cmsbuild]

A new Pull Request was created by @andreh7 for master.

It involves the following packages:

Configuration/Generator
GeneratorInterface/Core

@alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[alberto-sanchez]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30860/console Started: 2018/10/02 18:19

[cmsbuild]

+1
Tested at: 0a5a575
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24754/30860/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24754/30860/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3162800
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3162602
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[efeyazgan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@alberto-sanchez @andreh7 how was this practically tested? I mean, the change is straightforward, but was a workflow using this PR run? Furthermore, I assume this is for the future, not for backporting (as it changes the provenance)

[andreh7]

@fabiocos I tested this by running GeneratorInterface/GenFilters/test/test_doubleEMEnrichingHepMCfilter.py and I see from edmProvDump:

  HepMCFilter: PSet tracked = ({
   filterName: string tracked  = 'PythiaHepMCFilterGammaGamma'
   filterParameters: PSet tracked = ({
    AcceptPrompts: bool tracked  = true
    EnergyCut: double tracked  = 1
    ...
    dRTkMax: double tracked  = 0.2
   })
  })

while before it was between difficult to impossible to find out whether the filter parameters were the default ones or not.

---

I doubt that there is a workflow testing this filter but @alberto-sanchez may know. In fact, the algorithm of this filter (before #22980) was only used for PYTHIA samples and it should now be used with MADGRAPH samples.

---

In the past the double EM enrichment filter was only used for PYTHIA and for a handful of samples per campaign as far as I can tell, see the DAQ query dataset=/*DoubleEMEnriched*/*RunIIFall17*/GEN-SIM for example (which gives 6 datasets).

---

@grasph will produce samples with this filter (for physics comparison), I don't know however with which release this will be. If possible we'd like to benefit already from the tracking of the filter parameters in these.

[alberto-sanchez]

I am not aware on any workflow

[fabiocos]

+1

[andreh7]

thanks for merging this !

Some checks have been done in the context of #22980 which was the first time this filter algorithm was used with a generator other than PYTHIA while this pull request here is merely about making the parameters tracked and adding comments to the code describing what the parameters do.

The presentation in an H -> gamma gamma meeting by @gourangakole is here: https://indico.cern.ch/event/754287/contributions/3143029/