Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip getting event auxiliary if duplicate checker is disabled #24787

Merged
merged 1 commit into from Oct 11, 2018

Conversation

dan131riley
Copy link

RootFile::initializeDuplicateChecker() calls fillThisEventAuxiliary() even if checking for duplicates is disabled. We've observed that this can lead to the EventTree TTreeCache prefetching the entire EventAuxiliary branch, reading records scattered throughout the entire file. This PR skips all duplicate checker initialization if checking is disabled. DuplicateChecker::inputFileOpened() is a no-op if duplicate checking is disabled, so this change should be safe. Partially addresses issue #24780

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

A new Pull Request was created by @dan131riley (Dan Riley) for master.

It involves the following packages:

IOPool/Input

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30855/console Started: 2018/10/02 17:16

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24787/30855/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162800
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162601
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@smuzaffar smuzaffar modified the milestones: CMSSW_10_3_X, CMSSW_10_4_X Oct 10, 2018
@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 142a9a0 into cms-sw:master Oct 11, 2018
@dan131riley dan131riley deleted the bypass-duplicate-checker branch January 2, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants