New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip getting event auxiliary if duplicate checker is disabled #24787
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24787/6729 |
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages: IOPool/Input @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
RootFile::initializeDuplicateChecker() calls fillThisEventAuxiliary() even if checking for duplicates is disabled. We've observed that this can lead to the EventTree TTreeCache prefetching the entire EventAuxiliary branch, reading records scattered throughout the entire file. This PR skips all duplicate checker initialization if checking is disabled. DuplicateChecker::inputFileOpened() is a no-op if duplicate checking is disabled, so this change should be safe. Partially addresses issue #24780