Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix on FPix online clusters position maps (backport of #24770) #24788

Merged
merged 1 commit into from Oct 16, 2018

Conversation

arossi83
Copy link
Contributor

@arossi83 arossi83 commented Oct 2, 2018

Fix to bug which prevent FPix clusters position maps on plus side to be reset every 10LS. Backport of #24770

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

A new Pull Request was created by @arossi83 (Alessandro Rossi) for CMSSW_10_2_X.

It involves the following packages:

DQM/SiPixelPhase1Summary

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno, @jandrea this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@arossi83
Copy link
Contributor Author

arossi83 commented Oct 2, 2018

@threus I re-based the PR on 10_2_5 as requested. sorry for the wrong one made before.

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30858/console Started: 2018/10/02 17:57

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24788/30858/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2986766
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2986575
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@andrius-k
Copy link

backport of #24770

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit aa968dc into cms-sw:CMSSW_10_2_X Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants