New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workflow 136.7321 #24799
Remove workflow 136.7321 #24799
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24799/6745 |
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Configuration/PyReleaseValidation @pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@davidlange6 apparently nobody recalls why this workflow might still be useful |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
No objections! |
+1 |
+1 |
merge @kpedro88 this workflow is anyway for the past, not connected with upgrade |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
Test workflow 136.7321 is conflicting with existing L1 emulation for DQM, as defined in #24578 .
It is the only workflow in PyReleaseValidation where the L1repack sequence is run in the RECO+DQM step, and not only in the HLT one. As L1T brings a partial L1 emulation in the DQM sequence, the two collide and gives a Schedule configuration exception.
As 1) PdmV claims that this workflow was used for a limited period in Summer 2016 and never asked fo production after that, and 2) L1T experts do not see any utility in it, I propose to simply remove it.
Further expansion of use of the L1 emulator for DQM should anyway drive IMO to consider adding the L1 item in the RECO+DQM step, to transparently manage the L1 emulation without ad hoc addition of pieces.