Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workflow 136.7321 #24799

Merged
merged 1 commit into from Oct 5, 2018
Merged

Remove workflow 136.7321 #24799

merged 1 commit into from Oct 5, 2018

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Oct 4, 2018

Test workflow 136.7321 is conflicting with existing L1 emulation for DQM, as defined in #24578 .
It is the only workflow in PyReleaseValidation where the L1repack sequence is run in the RECO+DQM step, and not only in the HLT one. As L1T brings a partial L1 emulation in the DQM sequence, the two collide and gives a Schedule configuration exception.

As 1) PdmV claims that this workflow was used for a limited period in Summer 2016 and never asked fo production after that, and 2) L1T experts do not see any utility in it, I propose to simply remove it.

Further expansion of use of the L1 emulator for DQM should anyway drive IMO to consider adding the L1 item in the RECO+DQM step, to transparently manage the L1 emulation without ad hoc addition of pieces.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Oct 4, 2018

@davidlange6 apparently nobody recalls why this workflow might still be useful
@rekovic @thomreis this is what we have discussed
@Martin-Grunewald @slava77 @perrotta any objection on your side?

@fabiocos
Copy link
Contributor Author

fabiocos commented Oct 4, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30885/console Started: 2018/10/04 11:10

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24799/30885/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162909
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162711
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@Martin-Grunewald
Copy link
Contributor

No objections!

@fabiocos
Copy link
Contributor Author

fabiocos commented Oct 5, 2018

@prebello @pgunnell @zhenhu @kpedro88 could you please check? This is needed in order to clean the IB failure (not a big issue in itself, but annoying)

@prebello
Copy link
Contributor

prebello commented Oct 5, 2018

+1

@fabiocos
Copy link
Contributor Author

fabiocos commented Oct 5, 2018

+1

@fabiocos
Copy link
Contributor Author

fabiocos commented Oct 5, 2018

merge

@kpedro88 this workflow is anyway for the past, not connected with upgrade

@cmsbuild cmsbuild merged commit 1d23592 into cms-sw:master Oct 5, 2018
@kpedro88
Copy link
Contributor

kpedro88 commented Oct 8, 2018

+upgrade
(post facto)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@fabiocos fabiocos deleted the fc-cleanL1T branch October 31, 2018 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants