Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a unique exception for missing secondary files #24804

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Dr15Jones
Copy link
Contributor

Added a new EDMException category for the case where the secondary
source is given no input files. This exception happens alot in the
Release Validation tests so making it unique will help identify
the problem quicker.

Added a new EDMException category for the case where the secondary
source is given no input files. This exception happens alot in the
Release Validation tests so making it unique will help identify
the problem quicker.
@Dr15Jones
Copy link
Contributor Author

@cmsbot ping

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Utilities
IOPool/Input

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30889/console Started: 2018/10/04 18:07

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24804/30889/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162909
  • DQMHistoTests: Total failures: 70
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162642
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8426.92 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 150.0,... ): 3370.768 KiB JetMET/HIJetValidation
  • DQMHistoSizes: changed ( 158.0 ): 1685.384 KiB JetMET/HIJetValidation
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Oct 5, 2018

+1

@cmsbuild cmsbuild merged commit 89a472c into cms-sw:master Oct 5, 2018
@fabiocos
Copy link
Contributor

fabiocos commented Oct 5, 2018

@Dr15Jones as far as I can see in CMSSW_10_3_X_2018-10-05-1100 your update is making its job...

@Dr15Jones Dr15Jones deleted the uniqueExceptionSecSource branch October 30, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants