Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update relval recycle strings of 10_3_0_pre5 #24816

Merged
merged 3 commits into from Oct 9, 2018

Conversation

zhenhu
Copy link
Contributor

@zhenhu zhenhu commented Oct 5, 2018

including the strings to recycle with the new PREMIX datatier
/RelValFS_PREMIXUP15_PU25/CMSSW_10_3_0_pre5-PU25ns_103X_mcRun2_asymptotic_v1_FastSim-v1/PREMIX
/RelValPREMIXUP18_PU25/CMSSW_10_3_0_pre5-PU25ns_103X_upgrade2018_realistic_v7-v1/PREMIX

#24184 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

A new Pull Request was created by @zhenhu (Zhen Hu) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@zhenhu
Copy link
Contributor Author

zhenhu commented Oct 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30908/console Started: 2018/10/06 03:09

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24816/30908/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2436 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162979
  • DQMHistoTests: Total failures: 13195
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3149587
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.957 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 250202.181 ): -0.957 KiB SiStrip/MechanicalView
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2018

Pull request #24816 was updated. @pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please check and sign again.

@zhenhu
Copy link
Contributor Author

zhenhu commented Oct 9, 2018

Premix library for 2015, 2016, and 2017 produced:
/RelValPREMIXUP15_PU25/CMSSW_10_3_0_pre5-PU25ns_103X_mcRun2_asymptotic_v1-v1/PREMIX
/RelValPREMIXUP15_PU50/CMSSW_10_3_0_pre5-PU50ns_103X_mcRun2_startup_v1-v1/PREMIX
/RelValPREMIXUP17_PU25/CMSSW_10_3_0_pre5-PU25ns_103X_mc2017_realistic_v1-v1/PREMIX

@zhenhu
Copy link
Contributor Author

zhenhu commented Oct 9, 2018

please test workflow 250200.0,500200.0,250202.17

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30933/console Started: 2018/10/09 06:42

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24816/30933/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24816/250200.0_ZEE_13+ZEE_13+DIGIPRMXUP15_PU25+RECOPRMXUP15_PU25+HARVESTUP15_PU25
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24816/500200.0_ZEE_13+ZEE_13+DIGIPRMXUP15_PU50+RECOPRMXUP15_PU50+HARVESTUP15_PU50

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2438 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162979
  • DQMHistoTests: Total failures: 13195
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3149587
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.957 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 250202.181 ): -0.957 KiB SiStrip/MechanicalView
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@zhenhu
Copy link
Contributor Author

zhenhu commented Oct 9, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Oct 9, 2018

@kpedro88 could you please check and sign it?

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 9, 2018

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Oct 9, 2018

+1

@cmsbuild cmsbuild merged commit e77a1a5 into cms-sw:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants