Added the capability to switch the mode of charge asymmetry evaluation

[igv4321]

The HF rechit charge asymmetry flag is currently calculated independently from the status of the HF PMT anodes. The original idea was that the downstream code should look both at the asymmetry flag and at the anode status values in order to figure out whether the rechit should be rejected. However, this was never done. Currently, the simplest solution appears to be to calculate the charge asymmetry in reco only when both anodes have the "OK" status. This pull request gives HF reco this capability, but it is not turned on yet. The plan is to turn it on after some additional validation is performed by the HF Noise Studies Group.

This pull request will not modify any MC or data results.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24832/6781

[cmsbuild]

A new Pull Request was created by @igv4321 (Igor Volobouev) for master.

It involves the following packages:

RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mariadalfonso, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30934/console Started: 2018/10/09 07:02

[cmsbuild]

+1
Tested at: 02461c5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24832/30934/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24832/30934/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3162979
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3162781
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[perrotta]

+1

• Simple addition of the capability to calculate the HF rechit charge asymmetry flag only if the HF PMT anodes are in status "OK"
  • Otherwise there is no check, and it is not flagged when it does NOT passes the asymmetry cut
• Default configuration parameters do not change the previous behaviour (i.e. it keeps being always checked)
  • No changes are expected in the standard outputs, and none are observed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1