Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore minor precision differences in test. #2485

Merged
merged 1 commit into from Feb 15, 2014

Conversation

Dr15Jones
Copy link
Contributor

The test which uses ProducerWithPSetDesc was failing under gcc490
because python and C++ disagreed on the value of double(0.3) on the
last bit in the precision. The test was changed to accept a tolerance
of 1E-6.

The test which uses ProducerWithPSetDesc was failing under gcc490
because python and C++ disagreed on the value of double(0.3) on the
last bit in the precision. The test was changed to accept a tolerance
of 1E-6.
@ktf
Copy link
Contributor

ktf commented Feb 15, 2014

Out of curiosity, why the change?

ktf added a commit that referenced this pull request Feb 15, 2014
Misc fixes -- Ignore minor precision differences in test.
@ktf ktf merged commit 899d063 into cms-sw:CMSSW_7_1_X Feb 15, 2014
@Dr15Jones
Copy link
Contributor Author

@ktf
Copy link
Contributor

ktf commented Feb 15, 2014

I read that one, I was wondering if there was an explanation for
returning 0.30000000000000004 now.

On 15 Feb 2014, at 23:29, Chris Jones wrote:

https://hypernews.cern.ch/HyperNews/CMS/get/sw-develtools/2005.html


Reply to this email directly or view it on GitHub:
#2485 (comment)

@Dr15Jones Dr15Jones deleted the avoidPrecisionProblemInTest branch March 4, 2014 19:07
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Ignore minor precision differences in test.

It involves the following packages:

FWCore/Integration

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants