[10_3_X] Regional strip unpacker: support for legacy modes and bugfix for virgin raw

[pieterdavid]

Backport of #24851
As I understood, there is no plan to use virgin raw for the upcoming HI run, but we are submitting this bugfix to have it in place just in case.

CC: @icali @alesaggio

[cmsbuild]

A new Pull Request was created by @pieterdavid (Pieter David) for CMSSW_10_3_X.

It involves the following packages:

RecoLocalTracker/SiStripClusterizer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @makortel, @felicepantaleo, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @alesaggio, @gpetruc, @ebrondol, @threus, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Regional strip unpacker: support for legacy modes and bugfix for virgin raw #24851

[icali]

Yes, at the moment there is no plan to use VR mode this year. However, if during the HI run the tracker hybrid mode will not behave as expected (extremely unlikely because tested extensively), as a plan B we would need to run the tracker in VR mode. Being a piece of code that is completely orthogonal to pp data-taking, it could be beneficial to have it included also in 10_3_0.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31007/console Started: 2018/10/12 13:32

[cmsbuild]

+1
Tested at: 48343a3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24852/31007/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24852/31007/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3162979
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3162780
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[cmsbuild]

Pull request #24852 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31028/console Started: 2018/10/15 12:16

[cmsbuild]

+1
Tested at: 91d3de7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24852/31028/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24852/31028/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3162979
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3162781
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[slava77]

assign hlt
similar reasoning to #24851 (comment)

[cmsbuild]

New categories assigned: hlt

@Martin-Grunewald,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks

[slava77]

+1

for #24852 91d3de7

• HLT-specific clusterizer from RAW inputs
• the backport from the master Regional strip unpacker: support for legacy modes and bugfix for virgin raw #24851 is trivial: the same topic branch is used
• jenkins tests pass and comparisons with the baseline show no differences (the SiStripClusterizerFromRaw is used in the standard tests and its default behavior related to the standard SiStrip packing is unchanged)

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@icali as I understand that the RelVal campaign in 10_4_X will probe little about this PR, was any standalone test done?

[icali]

No, as of today we didn't test it further of what was done by Pieter. We simply verified that the changes were in line with what we know being a bug in 2015.

[fabiocos]

+1