Kalman BMTF Emu v2.7

[panoskatsoulis]

This is the latest BMTF emulator for the Kalman algorithm

[cmsbuild]

A new Pull Request was created by @panoskatsoulis for CMSSW_10_2_X.

It involves the following packages:

DataFormats/L1TMuon
L1Trigger/L1TMuonBarrel

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Kalman BMTF Emu v2.7 #24855

[panoskatsoulis]

backport of #24855
This PR includes code of #24237

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31015/console Started: 2018/10/13 11:41

[cmsbuild]

+1
Tested at: c24da1e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24856/31015/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24856/31015/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2986766
• DQMHistoTests: Total failures: 89
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2986487
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[panoskatsoulis]

hold

[cmsbuild]

Pull request #24856 was updated. @nsmith-, @rekovic, @cmsbuild, @thomreis can you please check and sign again.

[panoskatsoulis]

unhold

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31152/console Started: 2018/10/19 13:27

[cmsbuild]

-1

Tested at: a4fabca

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24856/31152/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

• Build:

I found compilation error when building:

>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-10-18-2300/src/L1Trigger/L1TMuon/src/MicroGMTConfiguration.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-10-18-2300/src/L1Trigger/L1TMuon/src/MicroGMTMatchQualSimpleLUT.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-10-18-2300/src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-10-18-2300/src/L1Trigger/L1TMuon/src/MicroGMTCancelOutUnit.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-10-18-2300/src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc: In static member function 'static void l1t::RegionalMuonRawDigiTranslator::fillRegionalMuonCand(l1t::RegionalMuonCand&, uint32_t, uint32_t, int, l1t::tftype)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-10-18-2300/src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc:39:23: error: 'segSel' was not declared in this scope
                   | ((segSel & 0x1) << 2);
                       ^~~~~~
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-10-18-2300/src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc:39:23: note: suggested alternative: 'setkey'
                   | ((segSel & 0x1) << 2);
                       ^~~~~~


• Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 16 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[panoskatsoulis]

This PR needs firstly the PR #24793 to be merged,
in order to succeed on building.
If I introduce here the required changes for compilation there will be a merge conflict with the above PR.

[thomreis]

Hi @panoskatsoulis
since 10_2 is not used anymore this PR can probably be closed.

[panoskatsoulis]

Hi @thomreis, yes this can be closed