Prepare for concurrent IOVs in FWCore #24858
Conversation
In preparation for concurrent IOVs, convert ESProducer produce methods to return unique_ptr. This affects modules used in Framework unit tests. Also modifies the Skeletons script that will generate a template for a new ESProducer. Note that Skeletons script had been broken by the changes to calls to the Python print function which were preparing for the migration to Python 3. This fixes that problem also.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24858/6821 |
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: FWCore/Integration @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
In preparation for concurrent IOVs, convert ESProducer
produce methods to return unique_ptr.
This affects modules used in Framework unit tests.
Also modifies the Skeletons script that will generate
a template for a new ESProducer.
Note that Skeletons script had been broken by the
changes to calls to the Python print function which
were preparing for the migration to Python 3. This
fixes that problem also.