HI O2O update: add new parameters and tidy up

[bundocka]

• Add required parameters for Heavy Ion running to CaloParamsHelperO2O.h
• Add required functions to L1TCaloParamsOnlineProd.cc
• Add demux LUTs to convertParamsToOnlineFormat.py (not specific to HI)
• Tidy up code so that parameter comparison between files is clearer

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24867/6836

[cmsbuild]

A new Pull Request was created by @bundocka for master.

It involves the following packages:

L1Trigger/L1TCalorimeter
L1TriggerConfig/L1TConfigProducers

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24867/6840

[cmsbuild]

Pull request #24867 was updated. @nsmith-, @rekovic, @cmsbuild, @thomreis can you please check and sign again.

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31035/console Started: 2018/10/15 16:50

[rekovic]

@bundocka
Please also provide a backport PR to 10_3_X.

[cmsbuild]

+1
Tested at: 1fc1a8f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24867/31035/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1fc1a8f
57a1f0f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24867/31035/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24867/31035/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24867/31035/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994723
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 13
• DQMHistoTests: Total successes: 2994497
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 72.149 KiB( 31 files compared)
• DQMHistoSizes: changed ( 136.85,... ): 3.671 KiB L1TEMU/L1TStage2CaloLayer2
• DQMHistoSizes: changed ( 136.85,... ): 1.140 KiB L1T/L1TStage2CaloLayer2
• DQMHistoSizes: changed ( 136.731,... ): 3.663 KiB L1TEMU/L1TStage2CaloLayer2
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1