Features to finalize CMSSW_10_3_0

[fabiocos]

This issue collects all the needed crucial features needed to build a CMSSW_10_3_0 that can be used for full-workflow tests in view of HI data taking. Part of the input comes from the XC meeting https://indico.cern.ch/event/762341/ see document https://docs.google.com/document/d/1EZYIoJaOkkIQlDgEbRHK0s2bwn5nOctFNX4ou8ZEj88/edit

Known needs so far (2018/10/19 5:10):

• Raw data remapper module Raw data remapper #24819 (merged in 10_4_X) -> Raw data remapper #24891 (10_3_X)
• Raw data remapper sequence Raw data remapper sequence #24910 (merged in 10_4_X) -> Raw data mapper sequence backport #24921 (10_3_X)
• L1T centrality fix Pr103x L1T update centrality, saturation fixes, EG eta restriction, jetphi ring subtraction (rebased) #24837 (merged in 10_3_X/10_4_X)
• SiStrip unpacker SiStrip unpacker: update packet code check in cmMedian (for nonstandard ZS modes) #24812 (10_4_X) -> [10_3_X] SiStrip unpacker: update packet code check in cmMedian (for nonstandard ZS modes) #24845 (10_3_X)
• HI centrality DQM HI Plots for the CaloLayer2 DQM #24835 (merged in 10_4_X) -> HI Plots for the CaloLayer2 DQM #24868 (10_3_X)
• L1T O2O cleaning HI O2O update: add new parameters and tidy up #24867 (merged in 10_4_X) -> HI O2O update: add new parameters and tidy up **103X BACKPORT** #24875 (10_3_X)
• L1T second HF min-bias feature bit Implement second HF min-bias feature bit #24847 (merged in 10_4_X) -> [10_3_X] Implement second HF min-bias feature bit #24857 (10_3_X)
• L1T Calo Layer 2 saturation fixes Calo Layer 2 saturation fixes #24883 (merged in 10_4_X) -> Calo Layer 2 saturation fixes **10_3_X BACKPORT** #24885 (10_3_X)

[cmsbuild]

A new Issue was created by @fabiocos Fabio Cossutti.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[fabiocos]

@icali @slava77 @perrotta please list here the possibly missing PRs
@rekovic Is anything more needed from L1T?
@Martin-Grunewald please let me know whether anything is needed by HLT before the 10_3_0 build, or whether more will have to be added afterwards

[boudoul]

Adding myself @boudoul as watcher

[perrotta]

@fabiocos

• I confirm that a backport of RPC Digi Collection Merger #24613 is wanted for 10_3_X, since they want to use it in the online DQM of the last part of this year data taking (i.e. HI). It will have no effect on the HI or standard workflows, though
• [10_3_X] SiStrip unpacker: update packet code check in cmMedian (for nonstandard ZS modes) #24845 (backport of SiStrip unpacker: update packet code check in cmMedian (for nonstandard ZS modes) #24812) is also welcome. Again, in the standard configuration it will have no effect on the HI workflows, and it affects only special (non-production) setups.

[rekovic]

@fabiocos
We would also like a backport of tidy-up of HI L1T O2O #24867

[rekovic]

Also the L1T DQM would need a backport
#24868

[Martin-Grunewald]

@fabiocos
At this stage, from the HLT side, we expect several menu updates, esp. of course the HIon menu and related knock-on effects, which may however come only after 10_3_0 is out.

[mguilbau]

Hi, I believe we also need #24883 in

[christopheralanwest]

@fabiocos The inclusion of PR#24857 in 10_3_X has been requested by @mguilbau.

[icali]

#24891 is the back porting of the Raw Data Remapper to 10_3_X. Adding the workflow PR later

[mandrenguyen]

Unfortunately, we will also need #24889 for prompt reco

[BetterWang]

Centrality reco 10_4_X (#24892), back port to 10_3_X (#24889).

[fabiocos]

@mandrenguyen @mguilbau @icali to be clear, here we should concentrate on the bare minimum for a meaningful test of data taking. Not crucial fixes may come later

[mandrenguyen]

@fabiocos Thanks, Fabio. As you correctly understood, #24889 is not needed for a meaningful test. Sorry for the noise.

[fabiocos]

@perrotta #24613 has been merged, although as it is it looks dummy, so I do not see any reason to rush for a backport (that does not yet exist). Please confirm my understanding, or explain why is it so urgent

[perrotta]

@fabiocos : no, it is not urgent. But it was in the intention of the proponents to have it eventualy in CMSSW_10_3_X, to be used for a while in online DQM during the data taking. The backport can wait for the next updates, then Fabio Cossutti <notifications@github.com> ha scritto:

…

@perrotta #24613 has been merged, although as it is it looks dummy, so I do not see any reason to rush for a backport (that does not yet exist). Please confirm my understanding, or explain why is it so urgent -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #24869 (comment)

[fabiocos]

@perrotta ok thanks, so it can exit the list of this issue

[mguilbau]

Hi,
#24883 and #24857
are fixing the trigger emulator decision for a large fraction of our objects. The agreement between data and emulator online is indeed something we wan't to check during the test. Nevertheless, this PR can be manually merged in DQM online if needed

[boudoul]

Dear @icali , please provide the PR for the workflow by tonight as you agreed. Thank you.

[icali]

sorry for the delay. The PR is #24910 for 10_4_X

[boudoul]

thanks @icali, the schedule is now really critical. Please @icali follow and address without any delay comments and suggestions from the ongoing review

[icali]

backport of #24910 is in PR #24921