Fixes for online beamspot, heavy-ion run in 2018 (10_3_X)

[sikler]

The HI reconstruction now uses the same labels as pp, changes are inherited via eras.
The code for the legacy client (beam_) was cleaned and straigthened out, better readability and similar or same cuts for pp and HI running.
The code for HLT-based client (beamhlt_) still needs a proper track and vertex collection for the HI run.
Documentation and background is at
https://twiki.cern.ch/twiki/bin/viewauth/CMS/OnlineBeamSpot#Sep_2018_legacy_and_or_HLT_based

[cmsbuild]

A new Pull Request was created by @sikler (Ferenc Siklér) for CMSSW_10_3_X.

It involves the following packages:

DQM/Integration

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@makortel, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[andrius-k]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31068/console Started: 2018/10/16 15:28

[andrius-k]

Hi @sikler, could you please make sure that there is the name of the subsystem in the title of the PR?

[sikler]

Hi @andrius-k: title changed, and have asked Tomas to edit the contact list.

[andrius-k]

@sikler thanks a lot! I added your Github username myself. I thought I can't do that and only the member of the group that is being edited has write access, but it worked. Soon the changes should be reflected in the page.

[cmsbuild]

-1

Tested at: 831b191

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24888/31068/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.788 step2

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step2_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Pull request #24888 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

[sikler]

Updating labels and collection names for the heavy-ion HLT-based (beamhlt) with fresh heavy-ion related infos, as
process.source.streamLabel = cms.untracked.string('streamHIDQMOnlineBeamspot')
...
process.dqmBeamMonitor.BeamFitter.TrackCollection = 'hltPFMuonMergingPPOnAA'
process.dqmBeamMonitor.primaryVertex = 'hltVerticesPFFilterPPOnAA'
process.dqmBeamMonitor.PVFitter.VertexCollection = 'hltVerticesPFFilterPPOnAA'

[cmsbuild]

Pull request #24888 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

[andrius-k]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31384/console Started: 2018/10/30 19:21

[cmsbuild]

+1
Tested at: 92876db
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24888/31384/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24888/31384/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3163099
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3162900
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

+1

correct backport of #25073

[fabiocos]

merge

@andrius-k please sign it in case for reference, as you have already signed the master version

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will be automatically merged.