Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove failing unit tests due to external update #24899

Closed
wants to merge 1 commit into from

Conversation

fabiocos
Copy link
Contributor

This PR is supposed to temporarily hide the failure in unit tests started in CMSSW_10_4_X_2018-10-11-1100 after the merge of cms-sw/cmsdist#4359 . An issue should be opened to keep in mind to revert this as soon as the problem is fixed in the external, see cms-sw/cmsdist#4359 (review)

@cmsbuild cmsbuild added this to the CMSSW_10_4_X milestone Oct 16, 2018
@fabiocos fabiocos changed the title Temporarily remove failing tests due to external update Temporarily remove failing unit tests due to external update Oct 16, 2018
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

PhysicsTools/PythonAnalysis

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31087/console Started: 2018/10/16 19:53

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24899/31087/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994645
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

@fabiocos , #24904 should fix the unit test issue. I would propose to close this PR and get #24904 in.

@fabiocos
Copy link
Contributor Author

replaced by #24904

@fabiocos fabiocos closed this Oct 18, 2018
@fabiocos fabiocos deleted the fc-silenceUnitTest104X branch October 31, 2018 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants