New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for concurrent IOVs, Fireworks & FastSimulation #24911
Prepare for concurrent IOVs, Fireworks & FastSimulation #24911
Conversation
Change return type of produce functions from shared_ptr to unique_ptr. Note that for the TGeo related classes this moves them in the right direction, but because of their dependence on TGeo they still will not work with concurrent IOVs. More work would need to be done.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24911/6877 |
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: FastSimulation/SimplifiedGeometryPropagator @ssekmen, @Dr15Jones, @lveldere, @civanch, @mdhildreth, @cmsbuild, @alja can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Change return type of produce functions from shared_ptr
to unique_ptr. Note that for the TGeo related classes
this moves them in the right direction, but because of
their dependence on TGeo they still will not work
with concurrent IOVs. More work would need to be done.