Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker Alignment - Fix to conddb function in validation and migration to common EOS storage #24950

Merged

Conversation

muhammadansariqbal
Copy link
Contributor

@muhammadansariqbal muhammadansariqbal commented Oct 19, 2018

Backport of #24952

This PR handles the following:

  • Fixes a broken conddb function in CMSSW_10_3_X

  • Changes the storage area for alignment validation output files to the tracker alignment group area instead of the user's personal caf storage space

Being requested in coordination with @hroskes @connorpa

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2018

A new Pull Request was created by @muhammadansariqbal (Muhammad Ansar Iqbal) for CMSSW_10_3_X.

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

…outputs being overwritten owing to default names.
@cmsbuild
Copy link
Contributor

Pull request #24950 was updated. @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please check and sign again.

@muhammadansariqbal
Copy link
Contributor Author

backport of #24952

@tocheng
Copy link
Contributor

tocheng commented Oct 23, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31221/console Started: 2018/10/23 10:21

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@pohsun
Copy link

pohsun commented Oct 23, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24950/31221/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3163099
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162901
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 00dbe7f into cms-sw:CMSSW_10_3_X Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants