SiStripMonitorClient: Fix caching logic in SiStripBadComponentInfo

[schneiml]

... by removing it. Also avoid a needless copy.

Thanks to @Dr15Jones and @makortel in #24924 for pointing out that this logic seems to be quite broken.

@mmusich this seems to fix the crash with multi-run harvesting, but it is hard to validate for me if the basic behavior changed. But, the change seems safe from the technical side.

Required for #24920, but independent.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24955/6927

[mmusich]

hard to validate for me if the basic behavior changed.

@schneiml we shall see it in the relval comparisons (as this module is tested there).

[andrius-k]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31197/console Started: 2018/10/22 21:10

[cmsbuild]

A new Pull Request was created by @schneiml (Marcel Schneider) for master.

It involves the following packages:

DQM/SiStripMonitorClient

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@hdelanno, @fioriNTU, @jandrea, @idebruyn, @threus, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 3c1d9c2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24955/31197/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24955/31197/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994644
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1