Bug fixes to Run2_2018_pp_on_AA in EI and DQM

[mandrenguyen]

Crashes in a replay using the Run2_2018_pp_on_AA era were identified in:
https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/2031/1/1/1/1.html

These crashes are not spotted in the relevant MC workflow (158), as they only occur in data validation.
They were reproduced using the following driver command, which executes the real data version.
cmsDriver.py reco --runUnscheduled --conditions auto:phase1_2018_realistic_hi -s RAW2DIGI,L1Reco,RECO,EI,VALIDATION:@standardValidation,DQM:@common+@standardDQM+@ExtraHLT --datatier AOD,DQMIO -n 2 --era Run2_2018_pp_on_AA --eventcontent AOD,DQM

This can be tested on the DIGI output from wf 158

103X version coming.

@icali

[fabiocos]

@smuzaffar why did the bot not start the usual procedure?

[fabiocos]

code-check

[fabiocos]

code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24958/6931

[andrius-k]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31200/console Started: 2018/10/22 21:57

[cmsbuild]

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

CommonTools/ParticleFlow
DQMOffline/Configuration
DQMOffline/RecoB

@perrotta, @andrius-k, @kmaeshima, @schneiml, @monttj, @cmsbuild, @jfernan2, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@rappoccio, @swertz, @imarches, @ahinzmann, @smoortga, @acaudron, @HeinerTholen, @jdolen, @mverzett, @JyothsnaKomaragiri, @gkasieczka, @threus, @cbernet, @ferencek, @pvmulder, @clelange, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 8b1f277
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24958/31200/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24958/31200/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994644
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24958/6960

[cmsbuild]

Pull request #24958 was updated. @perrotta, @andrius-k, @kmaeshima, @schneiml, @monttj, @cmsbuild, @jfernan2, @slava77, @gpetruc, @arizzi can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31251/console Started: 2018/10/24 17:00

[cmsbuild]

+1
Tested at: 74d35af
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24958/31251/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24958/31251/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 3
• DQMHistoTests: Total successes: 2994642
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.136 KiB( 31 files compared)
• DQMHistoSizes: changed ( 25.0,... ): 0.004 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 25.0,... ): 0.004 KiB MessageLogger/Warnings
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #24958 74d35af

• fixups for standard sequence parts running without PAT in pp_on_AA setup
• jenkins tests pass
• local test (done with the 10_3_X version) show that the HI workflow without PAT step now runs OK

[fabiocos]

@jfernan2 @andrius-k could you please check and sign it?

[fabiocos]

+1

[fabiocos]

merge

DQM already signed, latest changes do not affect their part

[andrius-k]

+1

Signing for the sake of completeness.