[10_3_X] Fix APV shot cleaner for 10bit

[pieterdavid]

Backport of #24961

CC: @icali

[cmsbuild]

A new Pull Request was created by @pieterdavid (Pieter David) for CMSSW_10_3_X.

It involves the following packages:

RecoLocalTracker/SiStripClusterizer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @makortel, @felicepantaleo, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @alesaggio, @gpetruc, @ebrondol, @threus, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix APV shot cleaner for 10bit #24961

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31213/console Started: 2018/10/23 09:25

[cmsbuild]

+1
Tested at: 81bcb2d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24962/31213/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24962/31213/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3163099
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3162900
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[perrotta]

+1

• (Same as Fix APV shot cleaner for 10bit #24961)
• The fix implements what written in the description
• The issue of the blind spot in 10 bits mode when the largest digi is 254 or 255 remains, but we take the author's evaluation that this should never happen in practice
  • There are no additional drawbacks with this PR, though
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1