Finalize migration to consumes for RecoEgamma/EgammaHLT*

[matteosan1]

Migration needed update of EcalClusterLazyTools class which in turn touched some offline packages.
Tested on both HLT and offline reconstruction.
Depends on PU #2378.

[cmsbuild]

A new Pull Request was created by @matteosan1 (Matteo Sani) for CMSSW_7_1_X.

Finalize migration to consumes for RecoEgamma/EgammaHLT*

It involves the following packages:

DQM/Physics
DQMOffline/Trigger
EgammaAnalysis/ElectronTools
HLTrigger/HLTanalyzers
PhysicsTools/PatAlgos
RecoEcal/EgammaCoreTools
RecoEgamma/EgammaHLTAlgos
RecoEgamma/EgammaHLTProducers
RecoEgamma/EgammaPhotonAlgos
RecoEgamma/EgammaPhotonProducers
RecoEgamma/EgammaTools
RecoEgamma/ElectronIdentification
RecoHI/HiEgammaAlgos
TauAnalysis/MCEmbeddingTools
Validation/EcalClusters

@perrotta, @cmsbuild, @civanch, @thspeer, @danduggan, @fwyzard, @mdhildreth, @monttj, @Martin-Grunewald, @anton-a, @nclopezo, @rovere, @deguio, @slava77, @vadler, @Degano, @ojeda can you please review it and eventually sign? Thanks.
@TaiSakuma, @jazzitup, @nhanvtran, @yenjie, @kurtejung, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[monttj]

+1

[cmsbuild]

-1
When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 18-Feb-2014 10:30:48 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EgammaHLTRegionalPixelSeedGeneratorProducers label='hltL1SeededEgammaRegionalPixelSeedGenerator'
Exception Message:
Parameter "SeedingLayers" should be defined as a tracked InputTag.
The type in the configuration is incorrect.
----- End Fatal Exception -------------------------------------------------

8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 18-Feb-2014 10:32:26 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EgammaHLTRegionalPixelSeedGeneratorProducers label='hltL1SeededEgammaRegionalPixelSeedGenerator'
Exception Message:
Parameter "SeedingLayers" should be defined as a tracked InputTag.
The type in the configuration is incorrect.
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 18-Feb-2014 10:32:58 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EgammaHLTRegionalPixelSeedGeneratorProducers label='hltL1SeededEgammaRegionalPixelSeedGenerator'
Exception Message:
Parameter "SeedingLayers" should be defined as a tracked InputTag.
The type in the configuration is incorrect.
----- End Fatal Exception -------------------------------------------------

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 18-Feb-2014 10:40:34 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EgammaHLTRegionalPixelSeedGeneratorProducers label='hltL1SeededEgammaRegionalPixelSeedGenerator'
Exception Message:
Parameter "SeedingLayers" should be defined as a tracked InputTag.
The type in the configuration is incorrect.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2497/207/summary.html

[Martin-Grunewald]

Please note that you MUST also include PR #2378, it will indeed not work without that one!

[perrotta]

Then the two pull requests are not mergeable now...

I think it is better if tests on this pull requests are worked out
only as soon as #2378 is merged (hopefully soon!) and this PR is
rebased accordingly.

Andrea

Martin Grunewald notifications@github.com ha scritto:

Please note that you MUST also include PR #2378, it will indeed not
work without that one!

---

Reply to this email directly or view it on GitHub:
#2497 (comment)

---

This message was sent using IMP, the Internet Messaging Program.

[nclopezo]

@perrotta
Hi Andrea,
This pull request has become unmergeable. Could you please rebase it?

[perrotta]

David Mendez notifications@github.com ha scritto:

@perrotta
Hi Andrea,
This pull request has become unmergeable. Could you please rebase it?

Hi David @nclopezo.

I would be happy to do it, but I'd rather let the Matteo @matteosan1
doing it, as he is the actual proposer of this PR...

---

Reply to this email directly or view it on GitHub:
#2497 (comment)

---

This message was sent using IMP, the Internet Messaging Program.

[matteosan1]

Rebased on top of latest 71X.

[cmsbuild]

Pull request #2497 was updated. @perrotta, @cmsbuild, @civanch, @thspeer, @danduggan, @fwyzard, @mdhildreth, @monttj, @Martin-Grunewald, @anton-a, @nclopezo, @rovere, @deguio, @slava77, @vadler, @Degano, @ojeda can you please check and sign again.

[Martin-Grunewald]

-1

Rebasing is not allowed to affect HLTrigger/Configuration

[slava77]

+1

#2497 b535452

code diffs ok

integration tests check based on jenkins

[ktf]

@deguio @danduggan @ojeda can you please review all the pull requests that you have still pending and eventually sign? Looking at them every two weeks is not acceptable, especially since now you have the automatic tests going on (or not?).

[deguio]

ciao @ktf
we have failures in the automatic tests which I didn't have time to investigate yet. going to do that later. probably they are not related but I want to be sure.
sorry for being late.

F.

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?