New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.4.X] add missing eventSetupPathsKey swap for HI 2018 #24975
[10.4.X] add missing eventSetupPathsKey swap for HI 2018 #24975
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24975/6946 |
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Calibration/TkAlCaRecoProducers @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
@mmusich your comment means that a backport of this PR should be linked to a corresponding update of a GT, otherwise it will break the release, am I correct? |
@fabiocos technically it won't break the relvals as this AlCaReco is not excercised yet in this mode (i.e. using the |
Just to be clear, when I say update I just mean an append IOV, the GT doesn't need to be necessarily changed. |
+1 |
Greetings,
as the
HLT_HIZeroBias_FirstCollisionAfterAbortGap_v*
trigger has been confirmed for the HI HLT menu for 2018 PbPb data-taking, it would be good to use the HI trigger biteventSetupPathsKey
. This is part of the same campaign of adjusting the pp ALCARECO for thepp_on_AA
era: #24596.Once merged, an update of the Express GT will be needed as at the moment the key
SiStripCalMinBiasAAGHI
is not available.