Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.4.X] add missing eventSetupPathsKey swap for HI 2018 #24975

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 23, 2018

Greetings,
as the HLT_HIZeroBias_FirstCollisionAfterAbortGap_v* trigger has been confirmed for the HI HLT menu for 2018 PbPb data-taking, it would be good to use the HI trigger bit eventSetupPathsKey. This is part of the same campaign of adjusting the pp ALCARECO for the pp_on_AA era: #24596.
Once merged, an update of the Express GT will be needed as at the moment the key SiStripCalMinBiasAAGHI is not available.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Calibration/TkAlCaRecoProducers

@cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @threus, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@tocheng
Copy link
Contributor

tocheng commented Oct 23, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31230/console Started: 2018/10/23 15:39

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@tocheng
Copy link
Contributor

tocheng commented Oct 23, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24975/31230/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994645
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

@mmusich your comment means that a backport of this PR should be linked to a corresponding update of a GT, otherwise it will break the release, am I correct?

@mmusich
Copy link
Contributor Author

mmusich commented Oct 24, 2018

@fabiocos technically it won't break the relvals as this AlCaReco is not excercised yet in this mode (i.e. using the pp_on_AA_2018 era) in any workflow, but if the backport is merged indeed before running this at tier-0 an update of the express GT is needed.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 24, 2018

Just to be clear, when I say update I just mean an append IOV, the GT doesn't need to be necessarily changed.

@fabiocos
Copy link
Contributor

@mmusich ok thank
@lpernie @tocheng what is the plan for such an update?

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c337d88 into cms-sw:master Oct 24, 2018
@tocheng
Copy link
Contributor

tocheng commented Oct 24, 2018

@mmusich ok thank
@lpernie @tocheng what is the plan for such an update?

@fabiocos No later than next CMSSW_10_3_X release where merge of #24976 is merged
We are going to append a new IOV to the current trigger selection to include all the changes needed for heavy Ion data taking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants