Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build/run cuda tests if cuda does not support gcc version #24983

Merged
merged 3 commits into from Oct 29, 2018
Merged

Do not build/run cuda tests if cuda does not support gcc version #24983

merged 3 commits into from Oct 29, 2018

Conversation

smuzaffar
Copy link
Contributor

This make use of new cuda-gcc-support tool to build/run unit tests based in cuda gcc support. This should allow us to build error free GCC 820 IBs and releases.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#4449

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4449

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DataFormats/CaloRecHit
DataFormats/DetId
DataFormats/HcalDetId
DataFormats/HcalDigi
DataFormats/Math
Utilities/General

@perrotta, @smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @rovere, @Martin-Grunewald, @wddgit, @mariadalfonso this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#4449

@cmsbuild
Copy link
Contributor

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#4449

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 25, 2018

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4449
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31264/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24983/31264/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994645
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor Author

+1

@civanch
Copy link
Contributor

civanch commented Oct 26, 2018

+1

@perrotta
Copy link
Contributor

+1

  • Technical
  • Jenkins tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor Author

@fabiocos can we get this in? This should fix build time errors for gcc82

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants