Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure HcalMinBias AlCaReco for heavy Ion 2018 #25007

Merged
merged 1 commit into from Oct 26, 2018

Conversation

tocheng
Copy link
Contributor

@tocheng tocheng commented Oct 25, 2018

Greetings,

The PR is to add HcalMinBiasHI into the AlCaReco stream.
The HcalMinBias in the AlCaReco stream is replaced by sequence in HcalMinBiasHI using the pp_on_AA_2018 era.
Also the HcalMinBiasOutput is replaced by the HcalMinBiasHIOut using the pp_on_AA_2018 era.

The configuration is checked using
python $CMSSW_BASE/src/Configuration/DataProcessing/test/RunPromptReco.py --scenario hcalnzsEra_Run2_2018_pp_on_AA --reco --aod --dqmio --global-tag 103X_dataRun2_Prompt_v2 --lfn=/store/whatever --alcareco HcalCalMinBias

After changing pickle to python config,
one can see that the HcalCalMinBias path and output is replaced by the path and output in HcalCalMinBiasHI

And one can also use streamer file from HI test
process.source = cms.Source("NewEventStreamFileReader",
fileNames = cms.untracked.vstring('file:/eos/cms/store/t0streamer/Data/HIPhysicsCommissioning/000/325/112/run325112_ls0006_streamHIPhysicsCommissioning_StorageManager.dat')
)
I ran 10 events without crash.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tocheng (Tongguang) for master.

It involves the following packages:

Calibration/HcalAlCaRecoProducers
DQMOffline/Configuration

@andrius-k, @kmaeshima, @schneiml, @tocheng, @cmsbuild, @franzoni, @jfernan2, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @threus, @swertz, @tocheng, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@tocheng
Copy link
Contributor Author

tocheng commented Oct 25, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 25, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31278/console Started: 2018/10/26 00:06

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@tocheng
Copy link
Contributor Author

tocheng commented Oct 26, 2018

@deguio This is something you want to follow

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25007/31278/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994645
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

@tocheng @deguio @andrius-k can we converge on this by 1100 today? Or do you see issues to be clarified?

@tocheng
Copy link
Contributor Author

tocheng commented Oct 26, 2018

+1

@tocheng
Copy link
Contributor Author

tocheng commented Oct 26, 2018

@fabiocos Sorry for the delay, I approved the PR

@fabiocos
Copy link
Contributor

@tocheng in my check adding the streamer as input to prompt reco did not really process 10 events.
Nevertheless, the configuration as far as I can see looks modified as desired.

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@fabiocos
Copy link
Contributor

@andrius-k please check anyway and sign it for reference or comment

@cmsbuild cmsbuild merged commit 768b8a5 into cms-sw:master Oct 26, 2018
@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants