Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed GenHFHadronMatcher #25025

Merged
merged 3 commits into from Nov 15, 2018
Merged

Fixed GenHFHadronMatcher #25025

merged 3 commits into from Nov 15, 2018

Conversation

Dr15Jones
Copy link
Contributor

The nanoAOD jobs were crashing in GenHFHadronMatcher because of a missing simulation parentage of a tau. This was fixed with the first commit.
Took the opportunity to modernize the module, especially since it is being used in an 8 thread job.

@Dr15Jones
Protect against a missing mother of a tau
697eb84 
Avoid a segmentation fault in the case of a tau particle not
having a mother particle. This was seen during nanoAOD processing.
@Dr15Jones
Removed reference to ParticleDataTable
b73c820 
Although the ParticleDataTable was pulled from the EventSetup,
it was never used.
@Dr15Jones
Made GenHFHadronMatcher a global module
0914ef2 
It was possible to change all member data of GenHFHadronMatcher to
be const and the module was not calling any thread unsafe external
functions. It was therefore easy to convert to a global module.
In addition, it now used EDPutTokens and edm::Event::emplace which
further improve the efficiency of the module.
@cmsbuild cmsbuild added this to the CMSSW_10_3_X milestone Oct 26, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 26, 2018 •
edited

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_10_3_X.

It involves the following packages:

PhysicsTools/JetMCAlgos

@cmsbuild, @fgolf, @peruzzim, @monttj can you please review it and eventually sign? Thanks.
@imarches, @smoortga, @acaudron, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones Dr15Jones mentioned this pull request Oct 26, 2018
Closed
@Dr15Jones
Copy link
Contributor Author

backport #25026

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 26, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31304/console Started: 2018/10/26 18:06

@cmsbuild
Copy link
Contributor

+1
Tested at: 0914ef2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25025/31304/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25025/31304/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3163099
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162901
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@zhenhu
Copy link
Contributor

zhenhu commented Oct 26, 2018

please test workflow 10887.0,11087.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 26, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31317/console Started: 2018/10/26 23:56

@cmsbuild
Copy link
Contributor

-1

Tested at: 0914ef2

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25025/31317/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

The relvals timed out after 2 hours.

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@Dr15Jones
Copy link
Contributor Author

please test workflow 10887.0,11087.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 27, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31319/console Started: 2018/10/27 07:54

@cmsbuild
Copy link
Contributor

+1
Tested at: 0914ef2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25025/31319/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25025/31319/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3163099
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162900
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@zhenhu
Copy link
Contributor

zhenhu commented Oct 27, 2018

+1
Tested at: 0914ef2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25025/31319/summary.html

Hi @Dr15Jones , for some reason, I can not find logs for 10887.0 and 11087.0

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 1428216 into cms-sw:CMSSW_10_3_X Nov 15, 2018
@Dr15Jones Dr15Jones deleted the fixGenHFHadronMatcher branch May 26, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending backport-ok comparison-available orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_10_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @zhenhu @fabiocos