Fixed JetMET summary plot for HI DQM #25034

jusaviin · 2018-10-29T12:00:59Z

Backport #24993 to 10_3_X.

Connected histograms from HIJetValidation to the JetMET summary plot in case of pp_on_AA_2018 era. The JetMET summary plot was by default reading the pp histograms, which are disabled for HI. To give green light for jets in the summary plot, it is required that the mean pT is lower than 50 GeV. Also show "Not set" instead of "Bad" for blocks that are not connected for HI.

cmsbuild · 2018-10-29T12:02:37Z

A new Pull Request was created by @jusaviin (Jussi Viinikainen) for CMSSW_10_3_X.

It involves the following packages:

DQMOffline/JetMET

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @rappoccio, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Backported from Fixed JetMET summary plot for HI DQM #24993

andrius-k · 2018-10-29T14:16:02Z

please test

cmsbuild · 2018-10-29T14:16:22Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31333/console Started: 2018/10/29 15:17

cmsbuild · 2018-10-29T17:05:45Z

+1
Tested at: c0d9e1e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25034/31333/summary.html

cmsbuild · 2018-10-29T17:05:48Z

Comparison job queued.

cmsbuild · 2018-10-29T18:36:14Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25034/31333/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3163099
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3162899
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 4.918 KiB( 31 files compared)
DQMHistoSizes: changed ( 140.53,... ): 1.969 KiB JetMET/HIJetValidation
DQMHistoSizes: changed ( 158.0 ): 0.980 KiB JetMET/HIJetValidation
Checked 134 log files, 14 edm output root files, 32 DQM output files

andrius-k · 2018-10-30T09:40:13Z

+1

cmsbuild · 2018-10-30T09:40:29Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

jusaviin · 2018-10-30T09:50:43Z

backport of #24993

vargasa · 2018-10-30T21:33:44Z

DQMOffline/JetMET/src/DataCertificationJetMET.cc

+    meJetPhi[1] = iget_.get(newHistoName+cleaningdir+jetAlgo+"PFJets/Phi_EndCap");
+    meJetPhi[2] = iget_.get(newHistoName+cleaningdir+jetAlgo+"PFJets/Phi_Forward");
+    meJetPhi[3] = iget_.get(newHistoName+cleaningdir+jetAlgo+"CaloJets/Phi");
+    //meJetPhi[4] = iget_.get(newHistoName+cleaningdir+"JetPlusTrackZSPCorJetAntiKt5/Phi");


Is this removable?

Suggested change

//meJetPhi[4] = iget_.get(newHistoName+cleaningdir+"JetPlusTrackZSPCorJetAntiKt5/Phi");

I'd guess so. That is the pp part of the code that I did not touch in this commit (except by moving it inside the else block).

As this is a backport of #24993 and that PR is already merged to master, I would prefer not to remove these commented out parts of code here either for consistency.

@vargasa Do you think it is better to keep the code consistent with #24993 or remove these two lines of commented code? It does no harm to remove them from the backport if necessary.

@jusaviin Please double check nothing is broken in the repo history by removing them, and if so. I'd suggest to remove them. So we can keep the code cleaner :)

I checked that those lines have been commented out sometime in 2014. Most likely not needed ever again. I removed the lines and committed the update.

vargasa · 2018-10-30T21:34:05Z

DQMOffline/JetMET/src/DataCertificationJetMET.cc

+    meJetEta[1] = iget_.get(newHistoName+cleaningdir+jetAlgo+"PFJets/Eta");
+    meJetEta[2] = iget_.get(newHistoName+cleaningdir+jetAlgo+"PFJets/EtaFirst");
+    meJetEta[3] = iget_.get(newHistoName+cleaningdir+jetAlgo+"CaloJets/Eta");
+    //meJetEta[4] = iget_.get(newHistoName+cleaningdir+"JetPlusTrackZSPCorJetAntiKt5/Eta");


Is this removable?

I'd guess so. That is the pp part of the code that I did not touch in this commit (except by moving it inside the else block).

As this is a backport of #24993 and that PR is already merged to master, I would prefer not to remove these commented out parts of code here either for consistency.

jusaviin · 2018-11-01T08:52:04Z

backport of #24993

cmsbuild · 2018-11-01T14:26:07Z

Pull request #25034 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

andrius-k · 2018-11-01T15:40:47Z

please test

cmsbuild · 2018-11-01T15:41:04Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31423/console Started: 2018/11/01 16:42

cmsbuild · 2018-11-01T18:31:29Z

+1
Tested at: e978171
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25034/31423/summary.html

cmsbuild · 2018-11-01T18:31:32Z

Comparison job queued.

cmsbuild · 2018-11-01T19:50:43Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25034/31423/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3163099
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3162898
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 4.918 KiB( 31 files compared)
DQMHistoSizes: changed ( 158.0 ): 0.980 KiB JetMET/HIJetValidation
DQMHistoSizes: changed ( 140.53,... ): 1.969 KiB JetMET/HIJetValidation
Checked 134 log files, 14 edm output root files, 32 DQM output files

andrius-k · 2018-11-02T13:09:20Z

+1

cmsbuild · 2018-11-02T13:09:38Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-11-09T10:12:36Z

+1

Jussi Viinikainen added 2 commits October 29, 2018 11:51

Fixed JetMET summary plot for HI DQM

ad5a3d0

Apply code checks

c0d9e1e

cmsbuild added this to the CMSSW_10_3_X milestone Oct 29, 2018

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Oct 29, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 29, 2018

cmsbuild added tests-approved and removed tests-started labels Oct 29, 2018

cmsbuild added comparison-available and removed comparison-pending labels Oct 29, 2018

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Oct 30, 2018

vargasa reviewed Oct 30, 2018

View reviewed changes

Removed commented out code

e978171

cmsbuild added backport-ok comparison-pending dqm-pending pending-signatures tests-pending and removed fully-signed tests-approved labels Nov 1, 2018

cmsbuild added tests-started and removed tests-pending labels Nov 1, 2018

cmsbuild added tests-approved and removed tests-started labels Nov 1, 2018

cmsbuild added comparison-available and removed comparison-pending labels Nov 1, 2018

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Nov 2, 2018

cmsbuild added orp-approved and removed orp-pending labels Nov 9, 2018

cmsbuild merged commit 1de877d into cms-sw:CMSSW_10_3_X Nov 9, 2018

fabiocos mentioned this pull request Nov 9, 2018

Revert "Fixed JetMET summary plot for HI DQM" #25176

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed JetMET summary plot for HI DQM #25034

Fixed JetMET summary plot for HI DQM #25034

jusaviin commented Oct 29, 2018

cmsbuild commented Oct 29, 2018 •

edited

andrius-k commented Oct 29, 2018

cmsbuild commented Oct 29, 2018 •

edited

cmsbuild commented Oct 29, 2018

cmsbuild commented Oct 29, 2018

cmsbuild commented Oct 29, 2018

andrius-k commented Oct 30, 2018

cmsbuild commented Oct 30, 2018

jusaviin commented Oct 30, 2018

vargasa Oct 30, 2018

jusaviin Oct 30, 2018

jusaviin Oct 31, 2018

jusaviin Nov 1, 2018

vargasa Nov 1, 2018

jusaviin Nov 1, 2018

vargasa Oct 30, 2018

jusaviin Oct 30, 2018

jusaviin Oct 31, 2018

jusaviin commented Nov 1, 2018

cmsbuild commented Nov 1, 2018

andrius-k commented Nov 1, 2018

cmsbuild commented Nov 1, 2018 •

edited

cmsbuild commented Nov 1, 2018

cmsbuild commented Nov 1, 2018

cmsbuild commented Nov 1, 2018

andrius-k commented Nov 2, 2018

cmsbuild commented Nov 2, 2018

fabiocos commented Nov 9, 2018

Fixed JetMET summary plot for HI DQM #25034

Fixed JetMET summary plot for HI DQM #25034

Conversation

jusaviin commented Oct 29, 2018

cmsbuild commented Oct 29, 2018 • edited

andrius-k commented Oct 29, 2018

cmsbuild commented Oct 29, 2018 • edited

cmsbuild commented Oct 29, 2018

cmsbuild commented Oct 29, 2018

cmsbuild commented Oct 29, 2018

andrius-k commented Oct 30, 2018

cmsbuild commented Oct 30, 2018

jusaviin commented Oct 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jusaviin commented Nov 1, 2018

cmsbuild commented Nov 1, 2018

andrius-k commented Nov 1, 2018

cmsbuild commented Nov 1, 2018 • edited

cmsbuild commented Nov 1, 2018

cmsbuild commented Nov 1, 2018

cmsbuild commented Nov 1, 2018

andrius-k commented Nov 2, 2018

cmsbuild commented Nov 2, 2018

fabiocos commented Nov 9, 2018

cmsbuild commented Oct 29, 2018 •

edited

cmsbuild commented Oct 29, 2018 •

edited

cmsbuild commented Nov 1, 2018 •

edited